Indirect draw validation fixes#9604
Open
teoxoy wants to merge 8 commits into
Open
Conversation
`max_dynamic_offset` should be used to clamp `out_dynamic_offset` directly; aligning it to `dynamic_offset_stride` clamps `out_dynamic_offset` to a lower value which then causes `out_offset` to exceed the binding size.
ErichDonGubler
approved these changes
May 29, 2026
Member
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
LGTM, just a couple of nitpicks. Approving to unblock after resolution.
nitpick: Commit titles don't make it clear they all apply to indirect draws. This might be somewhat confusing for the rebase-and-merge flow, which I assume is what you want with the "commits review gud" checkbox in the OP.
| } | ||
| } | ||
|
|
||
| fn adjust_adapter_limits(&self, limits: &mut wgt::Limits) { |
Member
There was a problem hiding this comment.
nitpick: It seems over-generalizing to call this adjust_adapter_limits. Perhaps, for now, we can make it more concretely descriptive, i.e., adjust_limits_for_indirect_validation?
Contributor
There was a problem hiding this comment.
It might be worth cross-reference comments between this and hal's adjust_raw_limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
-
Description
See commits.
Testing
Added a test.
Squash or Rebase?
Rebase.
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.