Defer set_immediates to draw/dispatch call time#9597
Open
beicause wants to merge 5 commits into
Open
Conversation
…mmediate:overprovisioned_immediate_data:*`
…mmediate:render_bundle_execution_state_invalidation:*`
…mmediate:unused_variable:*`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Depends on #9569
Helps with #8556
Fixes #850
Description
Fixes #850 by defering
set_immediatesto draw/dispatch call timeWhen executing
SetImmediatecommand, we record the data and mark it as dirty, and then actually push the immediates to the GPU at draw/dispatch time.Encoding render bundles is similar, we conditionally push
SetImmediatecommand only before encoding draw/dispatch commands. Because of thisvalues_offsethas been removed. Instead we store each immediates in a Vec insideSetImmediate. I also considered usingSmallVec, but it would increase the size of all commands and I'm not sure if it's worth it.The above logic is applied in
wgpu-core. Alternative would be applying it inwgpu-hal.Testing
With this PR and gpuweb/cts#4646 most cts will pass:
I also added
wgpu-validationtests for render and render bundle. It's not necessary, but it doesn't hurt either.Squash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.