Skip to content

fix(vulkan): build pipeline barrier based on queue family properties#9594

Open
ruihe774 wants to merge 1 commit into
gfx-rs:trunkfrom
ruihe774:barrier-with-queue-properties
Open

fix(vulkan): build pipeline barrier based on queue family properties#9594
ruihe774 wants to merge 1 commit into
gfx-rs:trunkfrom
ruihe774:barrier-with-queue-properties

Conversation

@ruihe774
Copy link
Copy Markdown
Contributor

@ruihe774 ruihe774 commented May 26, 2026

Connections
Related: #7766

Description
Pipeline barriers are built wrt queue family properties. VERTEX_SHADER & FRAGMENT_SHADER are only specified if the queue supports GRAPHICS, and COMPUTE_SHADER if COMPUTE. The signature of map_buffer_usage_to_barrier is changed to accept queue_flags. This should benefit API users who create device by themselves and pass it to device_from_raw, so that they can make use of compute-only or transfer-only queues.

Testing
In-file tests are added to ensure map_buffer_usage_to_barrier is mapping correct barrier flags wrt queue_flags.

Squash or Rebase?
Single commit only

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@Wumpf Wumpf self-assigned this May 27, 2026
@inner-daemons
Copy link
Copy Markdown
Collaborator

CC @atlv24 :)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants