fix(vulkan): build pipeline barrier based on queue family properties#9594
Open
ruihe774 wants to merge 1 commit into
Open
fix(vulkan): build pipeline barrier based on queue family properties#9594ruihe774 wants to merge 1 commit into
ruihe774 wants to merge 1 commit into
Conversation
Collaborator
|
CC @atlv24 :))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Related: #7766
Description
Pipeline barriers are built wrt queue family properties.
VERTEX_SHADER&FRAGMENT_SHADERare only specified if the queue supportsGRAPHICS, andCOMPUTE_SHADERifCOMPUTE. The signature ofmap_buffer_usage_to_barrieris changed to acceptqueue_flags. This should benefit API users who create device by themselves and pass it todevice_from_raw, so that they can make use of compute-only or transfer-only queues.Testing
In-file tests are added to ensure
map_buffer_usage_to_barrieris mapping correct barrier flags wrtqueue_flags.Squash or Rebase?
Single commit only
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.