Skip to content

๐Ÿ›Fix : ๋งˆ์ดํŽ˜์ด์ง€ ํฌ์ŠคํŠธ ์นด๋“œ ์กฐํšŒ - #138

Merged
KongMezu merged 1 commit into
developfrom
refact/mypage
Nov 15, 2025
Merged

KongMezu merged 1 commit into
developfrom
refact/mypage

Conversation

@KongMezu

@KongMezu KongMezu commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

๐Ÿ”ฅ ์ž‘์—… ๋‚ด์šฉ

  • ๋ฆฌ๋‹ค์ด๋ž™ํŠธ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ

PR Point (To Reviewer)

๋งˆ์ดํŽ˜์ด์ง€ ํฌ์ŠคํŠธ ์นด๋“œ ์กฐํšŒ ๊ฐ€๋Šฅ

๋ฆฌ๋‹ค์ด๋ž™ํŠธ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ์œผ๋กœ ํด๋ฆญ์‹œ ์ƒ์„ธ ์กฐํšŒ ๊ฐ€๋Šฅํ•˜๊ฒŒ ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.

Summary by CodeRabbit

๋ฆด๋ฆฌ์Šค ๋…ธํŠธ

  • ๋ฒ„๊ทธ ์ˆ˜์ •

    • ์ €์žฅํ•œ ์—ฝ์„œ ์ด๋ฏธ์ง€ URL ์ฒ˜๋ฆฌ ๊ฐœ์„ ์œผ๋กœ ์ด๋ฏธ์ง€ ํ‘œ์‹œ ์•ˆ์ •์„ฑ ๊ฐ•ํ™”
    • ์—ฝ์„œ ์นด๋“œ ํด๋ฆญ ์‹œ ์ƒ์„ธ ํŽ˜์ด์ง€๋กœ ์ด๋™ํ•˜๋Š” ๋„ค๋น„๊ฒŒ์ด์…˜ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๊ฐœ์„  ์‚ฌํ•ญ

    • ์ €์žฅํ•œ ์—ฝ์„œ ์„น์…˜์˜ ๋ Œ๋”๋ง ์„ฑ๋Šฅ ์ตœ์ ํ™”
    • ์—ฝ์„œ ์นด๋“œ์˜ ๋Œ€์ฒด ํ…์ŠคํŠธ ์ฒ˜๋ฆฌ ๋‹จ์ˆœํ™”

@vercel

vercel Bot commented Nov 15, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
af-fe Ready Ready Preview Comment Nov 15, 2025 1:31pm

@coderabbitai

coderabbitai Bot commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

์—ฝ์„œ ์นด๋“œ ๋ Œ๋”๋ง ๋กœ์ง์„ ๊ฐ„์†Œํ™”ํ•˜๊ณ , ์นด๋“œ ํด๋ฆญ ์‹œ ์ƒ์„ธ ํŽ˜์ด์ง€๋กœ ๋„ค๋น„๊ฒŒ์ด์…˜ํ•˜๋Š” ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ์ด๋ฏธ์ง€ URL์„ ํŠธ๋ฆผ ์ฒ˜๋ฆฌํ•˜๊ณ  ๋Œ€์ฒด ํ…์ŠคํŠธ๋ฅผ ๋‹จ์ˆœํ™”ํ–ˆ์œผ๋ฉฐ, ๋น„ํ™œ์„ฑํ™” ์†์„ฑ์„ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

Cohort / File(s) ๋ณ€๊ฒฝ ์š”์•ฝ
PostcardContainer ๋ Œ๋”๋ง ๋กœ์ง ๊ฐœ์„ 
src/pages/mypage/components/PostcardContainer.tsx
์Šฌ๋กฏ๋ณ„ ๋ Œ๋”๋ง์„ ์กฐ๊ฑด๋ถ€ ๋งต์œผ๋กœ ๊ต์ฒด; ์ด๋ฏธ์ง€ URL ํŠธ๋ฆผ ์ฒ˜๋ฆฌ ๊ฐ•์ œ; alt ํ…์ŠคํŠธ ๋‹จ์ˆœํ™”; disabled/aria-disabled ์†์„ฑ ์ œ๊ฑฐ; React ํ‚ค ์กฐ์ •; Image ์š”์†Œ ์กฐ๊ฑด๋ถ€ ๋ž˜ํ•‘ ์ œ๊ฑฐ
์—ฝ์„œ ์ƒ์„ธ ํŽ˜์ด์ง€ ๋„ค๋น„๊ฒŒ์ด์…˜
src/pages/mypage/index.tsx
onClickCard ํ•ธ๋“ค๋Ÿฌ ์ถ”๊ฐ€๋กœ /mypage/postcard/{id}๋กœ ๋ผ์šฐํŒ…; PostcardContainer์— onClickCard ํ”„๋กญ ์ „๋‹ฌ; ์ปจํ…Œ์ด๋„ˆ์— ์ƒ๋Œ€ ์œ„์น˜ ์ง€์ • ๋ฐ z-index ์ ์šฉ
FlipCard ์ด๋ฏธ์ง€ URL ์ฒ˜๋ฆฌ
src/pages/mypage/postcard/[id].tsx
FlipCard์˜ frontSrc์— ํŠธ๋ฆผ๋œ imageUrl ์ „๋‹ฌ

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PostcardContainer
    participant mypage/index
    participant Router
    participant postcard/[id]
    participant FlipCard

    User->>PostcardContainer: ์—ฝ์„œ ์นด๋“œ ํด๋ฆญ
    PostcardContainer->>mypage/index: onClickCard(postcardId) ํ˜ธ์ถœ
    mypage/index->>Router: /mypage/postcard/{id}๋กœ ๋„ค๋น„๊ฒŒ์ด์…˜
    Router->>postcard/[id]: ํŽ˜์ด์ง€ ๋กœ๋“œ
    postcard/[id]->>postcard/[id]: imageUrl ํŠธ๋ฆผ ์ฒ˜๋ฆฌ
    postcard/[id]->>FlipCard: ํŠธ๋ฆผ๋œ imageUrl์„ frontSrc๋กœ ์ „๋‹ฌ
    FlipCard-->>User: ์—ฝ์„œ ์ƒ์„ธ ํ™”๋ฉด ๋ Œ๋”๋ง
Loading

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~12 minutes

  • PostcardContainer์˜ ๋ Œ๋”๋ง ๋กœ์ง ๋ณ€๊ฒฝ์€ ๋ช…ํ™•ํ•˜๊ณ  ๋ฐ˜๋ณต์ ์ธ ํŒจํ„ด
  • ๋„ค๋น„๊ฒŒ์ด์…˜ ๊ธฐ๋Šฅ ์ถ”๊ฐ€๋Š” ๊ฐ„๋‹จํ•œ ํ”„๋กญ ์ „๋‹ฌ ๋ฐฉ์‹
  • ์ด๋ฏธ์ง€ URL ํŠธ๋ฆผ ์ฒ˜๋ฆฌ๋Š” ์ผ๊ด€๋œ ๋ณ€๊ฒฝ

Possibly related PRs

Suggested labels

comment

Suggested reviewers

  • skyblue1232
  • jjangminii

Poem

๐Ÿฐ ์—ฝ์„œ ์นด๋“œ๋“ค์ด ์ฃผ๋ ์ฃผ๋ ,
ํด๋ฆญํ•˜๋ฉด ์ƒ์„ธ ํŽ˜์ด์ง€๋กœ ํ›จํ›จ~
์ด๋ฏธ์ง€ URL ์ •๋ฆฌํ•˜๊ณ ,
๋„ค๋น„๊ฒŒ์ด์…˜ ์—ฐ๊ฒฐํ•˜๋ฉด ์™„์„ฑ!
์ €์žฅํ•œ ์ถ”์–ต๋“ค, ํ•œ ๋ˆˆ์— ๋ณด๊ธฐ โœจ

Pre-merge checks and finishing touches

โŒ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage โš ๏ธ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check โ“ Inconclusive PR ์„ค๋ช…์ด ๋งค์šฐ ๊ฐ„๊ฒฐํ•˜์—ฌ ๋ณ€๊ฒฝ์‚ฌํ•ญ์˜ ์ „์ฒด ๋ฒ”์œ„๋ฅผ ํŒŒ์•…ํ•˜๊ธฐ ์–ด๋ ต์Šต๋‹ˆ๋‹ค. ํ•„์ˆ˜ ์„น์…˜๋“ค์ด ๋Œ€๋ถ€๋ถ„ ๋ฏธ์ž‘์„ฑ ์ƒํƒœ์ž…๋‹ˆ๋‹ค. ์ถ”ํ›„ ์ž‘์—… ์‚ฌํ•ญ, ์ด์Šˆ ๋ฒˆํ˜ธ, ํ”ผ๊ทธ๋งˆ ์Šคํฌ๋ฆฐ์ƒท ๋“ฑ ๋ˆ„๋ฝ๋œ ์„น์…˜๋“ค์„ ์ถ”๊ฐ€ํ•˜๊ณ  ๋ณ€๊ฒฝ์‚ฌํ•ญ์„ ๋” ์ƒ์„ธํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.
โœ… Passed checks (1 passed)
Check name Status Explanation
Title check โœ… Passed PR ์ œ๋ชฉ์ด ์ฃผ์š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์„ ๋ช…ํ™•ํ•˜๊ฒŒ ์š”์•ฝํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ๋งˆ์ดํŽ˜์ด์ง€ ํฌ์ŠคํŠธ์นด๋“œ ์กฐํšŒ ๊ธฐ๋Šฅ ์ˆ˜์ •์ด๋ผ๋Š” ํ•ต์‹ฌ ๋‚ด์šฉ์ด ์ž˜ ๋ฐ˜์˜๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค.
โœจ Finishing touches
  • ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refact/mypage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the comment ํ•„์š”ํ•œ ์ฃผ์„ ์ถ”๊ฐ€ ๋ฐ ๋ณ€๊ฒฝ label Nov 15, 2025
@github-actions

Copy link
Copy Markdown

๐Ÿท๏ธ Labeler has automatically applied labels based on your PR title, branch name, or commit message.
Please verify that they are correct before merging.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and canโ€™t be posted inline due to platform limitations.

โš ๏ธ Outside diff range comments (3)
src/pages/mypage/postcard/[id].tsx (1)

1-1: 'use client' ์ง€์‹œ์–ด๋ฅผ ์ œ๊ฑฐํ•˜์„ธ์š”.

Pages Router์—์„œ๋Š” 'use client' ์ง€์‹œ์–ด๊ฐ€ ๋ถˆํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. ์ด ํ”„๋กœ์ ํŠธ๋Š” App Router๊ฐ€ ์•„๋‹Œ Pages Router๋ฅผ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์œผ๋ฏ€๋กœ, ํ•ด๋‹น ์ง€์‹œ์–ด๋ฅผ ์ œ๊ฑฐํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

Based on learnings

-'use client';
src/pages/mypage/index.tsx (1)

1-1: 'use client' ์ง€์‹œ์–ด๋ฅผ ์ œ๊ฑฐํ•˜์„ธ์š”.

Pages Router์—์„œ๋Š” 'use client' ์ง€์‹œ์–ด๊ฐ€ ๋ถˆํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. ์ด ํ”„๋กœ์ ํŠธ๋Š” App Router๊ฐ€ ์•„๋‹Œ Pages Router๋ฅผ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์œผ๋ฏ€๋กœ, ํ•ด๋‹น ์ง€์‹œ์–ด๋ฅผ ์ œ๊ฑฐํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

Based on learnings

-'use client';
-
 import React, { useEffect } from 'react';
src/pages/mypage/components/PostcardContainer.tsx (1)

1-1: 'use client' ์ง€์‹œ์–ด๋ฅผ ์ œ๊ฑฐํ•˜์„ธ์š”.

Pages Router์—์„œ๋Š” 'use client' ์ง€์‹œ์–ด๊ฐ€ ๋ถˆํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. ์ด ํ”„๋กœ์ ํŠธ๋Š” App Router๊ฐ€ ์•„๋‹Œ Pages Router๋ฅผ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์œผ๋ฏ€๋กœ, ํ•ด๋‹น ์ง€์‹œ์–ด๋ฅผ ์ œ๊ฑฐํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

Based on learnings

-'use client';
-
 import Image from 'next/image';
๐Ÿงน Nitpick comments (1)
src/pages/mypage/components/PostcardContainer.tsx (1)

85-106: ๋ Œ๋”๋ง ๋กœ์ง ๋ฆฌํŒฉํ† ๋ง์ด ์ž˜ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

์กฐ๊ฑด๋ถ€ ๋งต์„ ์‚ฌ์šฉํ•œ ๋ Œ๋”๋ง ๋กœ์ง์ด ์ฝ”๋“œ๋ฅผ ๋‹จ์ˆœํ™”ํ•˜๊ณ  ๊ฐ€๋…์„ฑ์„ ํ–ฅ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค. postcardId๋ฅผ ํ‚ค๋กœ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ๋„ ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค.

์ ‘๊ทผ์„ฑ ํ–ฅ์ƒ์„ ์œ„ํ•ด button ์š”์†Œ์— aria-label์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์„ ๊ณ ๋ คํ•ด ๋ณด์„ธ์š”.

 <button
   key={card.postcardId}
   onClick={() => onClickCard?.(card.postcardId)}
   className={postcardCardStyle({ interactive: true })}
+  aria-label={`${card.placeName} ์—ฝ์„œ ๋ณด๊ธฐ`}
 >
๐Ÿ“œ Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 899901b and 565379a.

๐Ÿ“’ Files selected for processing (3)
  • src/pages/mypage/components/PostcardContainer.tsx (1 hunks)
  • src/pages/mypage/index.tsx (2 hunks)
  • src/pages/mypage/postcard/[id].tsx (1 hunks)
๐Ÿงฐ Additional context used
๐Ÿง  Learnings (1)
๐Ÿ“š Learning: 2025-10-31T17:34:04.352Z
Learnt from: jjangminii
Repo: geulDa/FE PR: 64
File: src/pages/map/result/components/ResultMap.tsx:3-3
Timestamp: 2025-10-31T17:34:04.352Z
Learning: The geulDa/FE project uses Next.js Pages Router (not App Router), so components should import useRouter from 'next/router' and should not use the 'use client' directive.

Applied to files:

  • src/pages/mypage/index.tsx
๐Ÿงฌ Code graph analysis (1)
src/pages/mypage/index.tsx (1)
src/pages/mypage/components/PostcardContainer.tsx (1)
  • PostcardContainer (59-110)
โฐ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-and-deploy
๐Ÿ”‡ Additional comments (4)
src/pages/mypage/postcard/[id].tsx (1)

61-61: ์ข‹์Šต๋‹ˆ๋‹ค!

์ด๋ฏธ์ง€ URL์— trim()์„ ์ ์šฉํ•˜์—ฌ ๋ถˆํ•„์š”ํ•œ ๊ณต๋ฐฑ์„ ์ œ๊ฑฐํ•˜๋Š” ๊ฒƒ์€ ์ข‹์€ ๋ฐฉ์–ด์  ํ”„๋กœ๊ทธ๋ž˜๋ฐ์ž…๋‹ˆ๋‹ค.

src/pages/mypage/index.tsx (2)

136-136: ์ข‹์Šต๋‹ˆ๋‹ค!

์—ฝ์„œ ํด๋ฆญ ์‹œ ์ƒ์„ธ ํŽ˜์ด์ง€๋กœ ์ด๋™ํ•˜๋Š” ๋„ค๋น„๊ฒŒ์ด์…˜ ๋กœ์ง์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ๊ตฌํ˜„๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๋™์  ๋ผ์šฐํŠธ ๊ตฌ์กฐ(/mypage/postcard/[id])์™€ ์ž˜ ๋งค์นญ๋ฉ๋‹ˆ๋‹ค.


129-132: z-index ๊ฐ’ ๊ฒ€์ฆ ๊ฒฐ๊ณผ - ํ—ค๋” z-๊ฐ’ ์žฌํ™•์ธ ํ•„์š”

๊ฒ€์‚ฌ ๊ฒฐ๊ณผ, ์›๋ณธ ์ฃผ์„์˜ ์ „์ œ๊ฐ€ ์ •ํ™•ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. Header ์ปดํฌ๋„ŒํŠธ๋Š” z-50์ด ์•„๋‹Œ z-[100]์„ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

๊ทธ๋Ÿฌ๋‚˜ ์‹ค์ œ ๋ฌธ์ œ๋Š” ๋‹ค๋ฆ…๋‹ˆ๋‹ค:

  • z-[100]์€ Header, PopupSet๊ณผ ๋™์ผํ•œ ๊ฐ’์œผ๋กœ ์ค‘๋ณต ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค
  • ๋ฐ˜๋ฉด map ๊ด€๋ จ ์ปดํฌ๋„ŒํŠธ์—์„œ๋Š” z-[2000], z-[9999] ๊ฐ™์€ ๋งค์šฐ ๋†’์€ ๊ฐ’์ด ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์–ด z-index ์ „๋žต ์ผ๊ด€์„ฑ์ด ๋ถ€์กฑํ•ฉ๋‹ˆ๋‹ค
  • ํ˜„์žฌ section์€ relative ํฌ์ง€์…”๋‹์„ ์‚ฌ์šฉํ•˜๋ฏ€๋กœ ๊ณ ์ •(fixed) ์š”์†Œ๋“ค๊ณผ์˜ ์ง์ ‘์ ์ธ ์Šคํƒ ์ถฉ๋Œ ์œ„ํ—˜์€ ๋‚ฎ์Šต๋‹ˆ๋‹ค

๊ถŒ์žฅ์‚ฌํ•ญ: ํ”„๋กœ์ ํŠธ ์ „์ฒด์˜ z-index ๋„ค์ด๋ฐ/๊ฐ’ ์ „๋žต์„ ๊ฒ€ํ† ํ•˜๊ณ  ์ •์˜ํ•˜์„ธ์š” (์˜ˆ: ์ผ๊ด€๋œ ๋ ˆ์ด์–ด ์‹œ์Šคํ…œ ํ™•๋ฆฝ).

src/pages/mypage/components/PostcardContainer.tsx (1)

93-93: ์ข‹์Šต๋‹ˆ๋‹ค!

์ด๋ฏธ์ง€ URL์— trim()์„ ์ ์šฉํ•˜์—ฌ API ์‘๋‹ต์— ํฌํ•จ๋  ์ˆ˜ ์žˆ๋Š” ๋ถˆํ•„์š”ํ•œ ๊ณต๋ฐฑ์„ ์ œ๊ฑฐํ•˜๋Š” ๊ฒƒ์€ ์ข‹์€ ๋ฐฉ์–ด์  ํ”„๋กœ๊ทธ๋ž˜๋ฐ์ž…๋‹ˆ๋‹ค.

@KongMezu
KongMezu merged commit 2880f95 into develop Nov 15, 2025
6 of 7 checks passed
@KongMezu KongMezu assigned KongMezu and unassigned jjangminii Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comment ํ•„์š”ํ•œ ์ฃผ์„ ์ถ”๊ฐ€ ๋ฐ ๋ณ€๊ฒฝ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants