SDK-2737: Expose IDV breakdown process property in .NET SDK#549
Open
mehmet-yoti wants to merge 2 commits into
Open
SDK-2737: Expose IDV breakdown process property in .NET SDK#549mehmet-yoti wants to merge 2 commits into
mehmet-yoti wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the optional process field on Doc Scan session report breakdown items, allowing SDK consumers to distinguish whether a breakdown was processed via AUTOMATED or EXPERT_REVIEW.
Changes:
- Added
ProcesstoBreakdownResponsewith JSON mapping to theprocessfield. - Updated
CheckResponseTestsfixtures/assertions and added a test for theEXPERT_REVIEWvalue. - Added
*.lscacheto.gitignore, but also (accidentally) committed multiple*.csproj.lscachecache files.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Yoti.Auth/DocScan/Session/Retrieve/BreakdownResponse.cs | Exposes the process field on breakdown items via a new Process property. |
| test/Yoti.Auth.Tests/DocScan/Session/Retrieve/Check/CheckResponseTests.cs | Extends breakdown parsing tests to cover process values (including EXPERT_REVIEW). |
| .gitignore | Ignores *.lscache going forward. |
| test/Yoti.Auth.Tests/Yoti.Auth.Tests.csproj.lscache | Editor cache file added to PR; should be removed from source control. |
| test/Yoti.Auth.Tests.Common/Yoti.Auth.Tests.Common.csproj.lscache | Editor cache file added to PR; should be removed from source control. |
| src/Yoti.Auth/Yoti.Auth.csproj.lscache | Editor cache file added to PR; should be removed from source control. |
| src/Examples/Profile/CoreExample/CoreExample.csproj.lscache | Editor cache file added to PR; should be removed from source control. |
| src/Examples/DocScan/DocScanExample/DocScanExample.csproj.lscache | Editor cache file added to PR; should be removed from source control. |
| src/Examples/DigitalIdentity/DigitalIdentity/DigitalIdentityExample.csproj.lscache | Editor cache file added to PR; should be removed from source control. |
| src/Examples/Aml/AmlExample/AmlExample.csproj.lscache | Editor cache file added to PR; should be removed from source control. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+5
| version=1 | ||
|
|
||
| # This file caches language service data to improve the performance of C# Dev Kit. | ||
| # It is not intended for manual editing. It can safely be deleted and will be | ||
| # regenerated automatically. For more information, see https://aka.ms/lscache |
Comment on lines
+1
to
+5
| version=1 | ||
|
|
||
| # This file caches language service data to improve the performance of C# Dev Kit. | ||
| # It is not intended for manual editing. It can safely be deleted and will be | ||
| # regenerated automatically. For more information, see https://aka.ms/lscache |
Comment on lines
+1
to
+5
| version=1 | ||
|
|
||
| # This file caches language service data to improve the performance of C# Dev Kit. | ||
| # It is not intended for manual editing. It can safely be deleted and will be | ||
| # regenerated automatically. For more information, see https://aka.ms/lscache |
Comment on lines
+1
to
+5
| version=1 | ||
|
|
||
| # This file caches language service data to improve the performance of C# Dev Kit. | ||
| # It is not intended for manual editing. It can safely be deleted and will be | ||
| # regenerated automatically. For more information, see https://aka.ms/lscache |
Comment on lines
+1
to
+5
| version=1 | ||
|
|
||
| # This file caches language service data to improve the performance of C# Dev Kit. | ||
| # It is not intended for manual editing. It can safely be deleted and will be | ||
| # regenerated automatically. For more information, see https://aka.ms/lscache |
Comment on lines
+1
to
+5
| version=1 | ||
|
|
||
| # This file caches language service data to improve the performance of C# Dev Kit. | ||
| # It is not intended for manual editing. It can safely be deleted and will be | ||
| # regenerated automatically. For more information, see https://aka.ms/lscache |
Comment on lines
+1
to
+5
| version=1 | ||
|
|
||
| # This file caches language service data to improve the performance of C# Dev Kit. | ||
| # It is not intended for manual editing. It can safely be deleted and will be | ||
| # regenerated automatically. For more information, see https://aka.ms/lscache |
| @@ -106,6 +106,24 @@ public void CheckBreakdownResponseIsParsed() | |||
| AssertBreakdownResponseValuesCorrect(breakdownResponse, response); | |||
| } | |||
|
|
|||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the
processproperty on IDV breakdown items retrieved from session reports, enabling clients to query whether a breakdown was processed throughAUTOMATEDorEXPERT_REVIEWchannels.Changes
Processproperty toBreakdownResponse.cswith JSON mapping to theprocessfield from API responsesCheckResponseTestswith:EXPERT_REVIEWprocess valueMotivation
The
processfield was already exposed in Java and PHP SDKs but missing from the .NET SDK. This change brings parity across SDKs and allows developers to distinguish between automated and expert-reviewed breakdown decisions.API Contract
The
processfield is optional in the IDV session report response. Supported values:AUTOMATED- Automated processingEXPERT_REVIEW- Expert review processing