fix(android): Use componentStack as fallback for missing error stack traces by antonis · Pull Request #5965 · getsentry/sentry-react-native

antonis · 2026-04-07T13:16:17Z

📢 Type of change

Bugfix

📜 Description

When React render errors occur on Android with Hermes, the error may arrive at ErrorUtils.setGlobalHandler without a usable .stack property (empty or message-only). However, React's ReactFiberErrorDialog attaches a .componentStack to the error object before it reaches the handler. The componentStack contains component locations with bundle offsets that can be symbolicated by Sentry.

This PR uses componentStack as a fallback for error.stack when the stack has no frames, so that eventFromException can extract frames with source locations.

The fix handles both cases:

error.stack is undefined/empty
error.stack is a message-only string with no frame lines (e.g. "Error: Value is undefined, expected an Object")

Note: The componentStack is a React component tree (not a JS execution stack). After symbolication, it shows which component caused the error and its source location, but not the exact call chain within the component. This is the best information available on the JS side for this class of errors.

💡 Motivation and Context

Fixes #5071

A user reported a fatal error "Value is undefined, expected an Object" arriving in Sentry with no stacktrace, while Crashlytics captured the same error with a full component stack as a JavascriptException. The root cause is that some Hermes/JSI errors have no .stack property, but React attaches .componentStack which contains the same location information.

See also: https://x.com/TheAnirudh/status/1954761591515476463

💚 How did you test it?

Added test verifying componentStack is used as fallback when .stack is missing
Added test verifying componentStack is used when .stack is message-only (no frames)
Added test verifying existing .stack with frames is not overridden
All 1216 tests pass, 0 lint errors
Verified defaultStackParser correctly parses the componentStack format including address at prefixes

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Verify with a real Android/Hermes app that the recovered component stack frames are correctly symbolicated

…traces When React render errors occur on Android with Hermes, the error may arrive at ErrorUtils.setGlobalHandler without a .stack property. However, React attaches a .componentStack with component locations and bundle offsets before the error reaches the handler. Use componentStack as a fallback for error.stack so that eventFromException can extract frames with source locations. Fixes #5071 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-04-07T13:16:43Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

fix(android): Use componentStack as fallback for missing error stack traces by antonis in #5965

fix(ios): Add SENTRY_PROJECT_ROOT env var for monorepo support by antonis in #5961
feat(ios): Add attachAllThreads option by antonis in #5960
fix(core): Lazy-load Metro internal modules to prevent Expo 55 import errors by lucas-zimerman in #5958
chore(deps): update Cocoa SDK to v9.9.0 by github-actions in #5956
chore(deps): update Maestro to v2.4.0 by github-actions in #5955
Feat: Fallback to stacktrace parsing by lucas-zimerman in #5946
fix(ci): Bump Node to 22 in size-analysis and testflight workflows by antonis in #5954
feat(playground): Open Sentry in desktop browser from Expo apps by antonis in #5947
chore(core): Bump sample app to React Native 0.84.1 by antonis in #5941
Size analysis for React Native SDK by alwx in #5949
chore(deps): bump lodash from 4.17.23 to 4.18.1 by dependabot in #5953
chore(deps): bump yauzl to ^3.2.1 by antonis in #5950
chore(deps): bump brace-expansion to ^2.0.3 by antonis in #5951
chore(deps): bump @xmldom/xmldom to fix XML injection by antonis in #5952

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-04-07T13:17:00Z

	Fails
🚫	Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 8c77549

CHANGELOG.md

antonis · 2026-04-07T13:30:20Z

@sentry review

antonis · 2026-04-07T13:30:30Z

@cursor review

sentry · 2026-04-07T13:32:44Z

Sentry Build Distribution

App Name	App ID	Version	Configuration	Install Page
Sentry RN	io.sentry.reactnative.sample	8.7.0 (82)	Release	Install Build

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/core/src/js/integrations/reactnativeerrorhandlers.ts

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit bc7535c. Configure here.}

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

lucas-zimerman · 2026-04-08T12:25:40Z

packages/core/src/js/integrations/reactnativeerrorhandlers.ts

+    // oxlint-disable-next-line typescript-eslint(no-unsafe-member-access)
+    if (error?.componentStack && (!error.stack || !hasStackFrames(error.stack))) {
+      // oxlint-disable-next-line typescript-eslint(no-unsafe-member-access)
+      error.stack = `${error.message || 'Error'}${error.componentStack}`;


shouldn't we add an extra space between the parameters, so Error is not clued to the componentStack message?

lucas-zimerman

nit comment, other than that, LGTM!

antonis commented Apr 7, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update changelog

bc7535c

fix: Also handle stack with no frames (message-only stack string)

583c991

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

sentry bot reviewed Apr 7, 2026

View reviewed changes

packages/core/src/js/integrations/reactnativeerrorhandlers.ts Show resolved Hide resolved

cursor bot reviewed Apr 7, 2026

View reviewed changes

antonis and others added 2 commits April 7, 2026 15:35

fix: Add null guard for error object in componentStack fallback

13b2959

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: Use optional chaining for error null check

8c77549

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

antonis marked this pull request as ready for review April 7, 2026 14:26

antonis requested review from alwx and lucas-zimerman as code owners April 7, 2026 14:26

lucas-zimerman reviewed Apr 8, 2026

View reviewed changes

lucas-zimerman approved these changes Apr 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(android): Use componentStack as fallback for missing error stack traces#5965

fix(android): Use componentStack as fallback for missing error stack traces#5965
antonis wants to merge 5 commits intomainfrom
antonis/fix-missing-stacktrace-android-v2

antonis commented Apr 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

antonis commented Apr 7, 2026

Uh oh!

antonis commented Apr 7, 2026

Uh oh!

sentry bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

lucas-zimerman Apr 8, 2026

Uh oh!

lucas-zimerman left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

antonis commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

antonis commented Apr 7, 2026

Uh oh!

antonis commented Apr 7, 2026

Uh oh!

sentry bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sentry Build Distribution

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Apr 7, 2026 •

edited

Loading

github-actions bot commented Apr 7, 2026 •

edited

Loading

github-actions bot commented Apr 7, 2026 •

edited

Loading

sentry bot commented Apr 7, 2026 •

edited

Loading