Skip to content

feat: Auto-create traces for MAUI navigation events #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 19 commits into
base: main
Choose a base branch
from

Fix threading issues around idleTimer

7a0395a
Select commit
Loading
Failed to load commit list.
Open

feat: Auto-create traces for MAUI navigation events #5111

Fix threading issues around idleTimer
7a0395a
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Apr 9, 2026 in 11m 6s

1 issue

code-review: Found 1 issue (1 medium)

Medium

ReaderWriterLockSlim _finishLock is never disposed - `src/Sentry/TransactionTracer.cs:21`

The _finishLock field of type ReaderWriterLockSlim is created but never disposed. ReaderWriterLockSlim implements IDisposable and holds native resources that should be released. The Dispose() method only calls Finish() which disposes _idleTimer but not _finishLock, leading to potential resource leaks when many transactions are created.

Duration: 11m 6s · Tokens: 4.7M in / 54.9k out · Cost: $7.79 (+extraction: $0.00)

Annotations

Check warning on line 21 in src/Sentry/TransactionTracer.cs

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

ReaderWriterLockSlim _finishLock is never disposed 

The `_finishLock` field of type `ReaderWriterLockSlim` is created but never disposed. `ReaderWriterLockSlim` implements `IDisposable` and holds native resources that should be released. The `Dispose()` method only calls `Finish()` which disposes `_idleTimer` but not `_finishLock`, leading to potential resource leaks when many transactions are created.
View more details on @sentry/warden