-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(attributes): Add more device context attributes #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
buenaflor
wants to merge
14
commits into
main
Choose a base branch
from
giancarlobuenaflor/add-device-context-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a78c7c2
feat(attributes): Add remaining device context attributes
buenaflor 799812a
chore: Add PR number to changelog entries
buenaflor 919e9e2
fix: regenerate attribute files to match source definitions
buenaflor 90811f9
feat(attributes): Add more device context and network connection attr…
buenaflor ad8779e
fix: Add symmetric alias between network.connection.type and device.c…
buenaflor f2f7fb3
Merge branch 'main' into giancarlobuenaflor/add-device-context-attrib…
buenaflor 93c72ca
fix: Complete symmetric aliases for connection type attribute group
buenaflor 746a8f4
fix: regenerate attribute files to include full alias lists
buenaflor 802f685
feat(attributes): Add device.archs attribute
buenaflor c600def
feat(attributes): Add device.timezone and device.locale attributes
buenaflor 2a65678
fix: Add PR number 303 to changelog entries for new device attributes
buenaflor ec28533
Merge branch 'main' into giancarlobuenaflor/add-device-context-attrib…
buenaflor 33907bb
fix: Align network.connection.type description with main branch
buenaflor 6e0a083
fix: Include PR reference in deprecated_attributes.json for device.lo…
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.archs", | ||
| "brief": "The CPU architectures of the device.", | ||
| "type": "string[]", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": ["arm64-v8a", "armeabi-v7a", "armeabi"], | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.archs attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.battery_level", | ||
| "brief": "The battery level of the device as a percentage (0-100).", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 100.0, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.battery_level attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.battery_temperature", | ||
| "brief": "The battery temperature of the device in Celsius.", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 25.0, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.battery_temperature attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.boot_time", | ||
| "brief": "A formatted UTC timestamp when the system was booted.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "2018-02-08T12:52:12Z", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.boot_time attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.charging", | ||
| "brief": "Whether the device was charging or not.", | ||
| "type": "boolean", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": false, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.charging attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.chipset", | ||
| "brief": "The chipset of the device.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "Qualcomm SM8550", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.chipset attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "key": "device.connection_type", | ||
| "brief": "The internet connection type currently being used by the device.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "wifi", | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "network.connection.type", | ||
| "reason": "This attribute is being deprecated in favor of network.connection.type" | ||
| }, | ||
| "alias": ["network.connection.type", "connectionType"], | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added and deprecated device.connection_type in favor of network.connection.type" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.cpu_description", | ||
| "brief": "A description of the CPU of the device.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.cpu_description attribute" | ||
| } | ||
| ] | ||
| } |
17 changes: 17 additions & 0 deletions
17
model/attributes/device/device__external_free_storage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.external_free_storage", | ||
| "brief": "External storage free size in bytes.", | ||
| "type": "integer", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 67108864000, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.external_free_storage attribute" | ||
| } | ||
| ] | ||
| } |
17 changes: 17 additions & 0 deletions
17
model/attributes/device/device__external_storage_size.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.external_storage_size", | ||
| "brief": "External storage total size in bytes.", | ||
| "type": "integer", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 134217728000, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.external_storage_size attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.free_storage", | ||
| "brief": "Free device storage in bytes.", | ||
| "type": "integer", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 107374182400, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.free_storage attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.id", | ||
| "brief": "Unique device identifier.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": true, | ||
| "example": "a1b2c3d4-e5f6-7890-abcd-ef1234567890", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.id attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "key": "device.locale", | ||
| "brief": "The locale of the device.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "en-US", | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "culture.locale", | ||
| "reason": "This attribute is being deprecated in favor of culture.locale" | ||
| }, | ||
| "alias": ["culture.locale"], | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added and deprecated device.locale in favor of culture.locale" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.low_memory", | ||
| "brief": "Whether the device was low on memory.", | ||
| "type": "boolean", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": false, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.low_memory attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.manufacturer", | ||
| "brief": "The manufacturer of the device.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": true, | ||
| "example": "Google", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.manufacturer attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.name", | ||
| "brief": "The name of the device. On mobile, this is the user-assigned device name. On servers and desktops, this is typically the hostname.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "localhost", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.name attribute" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.online", | ||
| "brief": "Whether the device was online or not.", | ||
| "type": "boolean", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": true, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.online attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.orientation", | ||
| "brief": "The orientation of the device, either \"portrait\" or \"landscape\".", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "portrait", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.orientation attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.processor_frequency", | ||
| "brief": "Processor frequency in MHz.", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 2400.0, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.processor_frequency attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "device.screen_density", | ||
| "brief": "The screen density of the device.", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 2.625, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [303], | ||
| "description": "Added device.screen_density attribute" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OTel has
device.model.name. Is there a semantic difference? Otherwise wdyt about using the OTel version?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
device.model.nameis represented by our device.model.and OTel
device.model.identifieris device.model_idI'd opt for the OTel one too, we can deprecate it at some point later