Skip to content

test: Remove attachAllThreads from undocumented options list#7776

Merged
philprime merged 1 commit intomainfrom
itay/docs-sync-attach-all-threads
Apr 22, 2026
Merged

test: Remove attachAllThreads from undocumented options list#7776
philprime merged 1 commit intomainfrom
itay/docs-sync-attach-all-threads

Conversation

@itaybre
Copy link
Copy Markdown
Contributor

@itaybre itaybre commented Apr 6, 2026

Description

Remove attachAllThreads from the undocumentedOptions set in SentryOptionsDocumentationSyncTests since the option is now documented in sentry-docs.

Motivation and Context

The attachAllThreads option (added in 9.9.0) was marked as undocumented with the comment "SDK not released yet". Now that 9.9.0 is released and the docs PR is up, this option should be validated by the sync test.

How did you test it?

The SentryOptionsDocumentationSyncTests will now validate that attachAllThreads is documented.

Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

The option is now documented in sentry-docs.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@itaybre itaybre marked this pull request as draft April 6, 2026 15:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.430%. Comparing base (a47ad66) to head (5737941).
⚠️ Report is 23 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7776       +/-   ##
=============================================
+ Coverage   85.401%   85.430%   +0.028%     
=============================================
  Files          487       487               
  Lines        29086     29513      +427     
  Branches     12602     12823      +221     
=============================================
+ Hits         24840     25213      +373     
- Misses        4196      4246       +50     
- Partials        50        54        +4     

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47ad66...5737941. Read the comment docs.

@itaybre
Copy link
Copy Markdown
Contributor Author

itaybre commented Apr 6, 2026

Waiting for getsentry/sentry-docs#17258

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Apr 9, 2026
@itaybre itaybre marked this pull request as ready for review April 9, 2026 14:38
@itaybre
Copy link
Copy Markdown
Contributor Author

itaybre commented Apr 20, 2026

Docs PR was merged, so we can merge this too now

@philprime philprime enabled auto-merge (squash) April 22, 2026 08:28
Copy link
Copy Markdown
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit 7b089f4 into main Apr 22, 2026
248 of 270 checks passed
@philprime philprime deleted the itay/docs-sync-attach-all-threads branch April 22, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants