ref(transactions): Send extracted spans and profiles directly to store#6029
Open
Dav1dde wants to merge 3 commits into
Open
ref(transactions): Send extracted spans and profiles directly to store#6029Dav1dde wants to merge 3 commits into
Dav1dde wants to merge 3 commits into
Conversation
Dav1dde
changed the title
Dav1dde
force-pushed
the
dav1d/store-spans-from-transactions
branch
3 times, most recently
from
5aff409 to
3b09a51
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Dav1dde
force-pushed
the
dav1d/store-spans-from-transactions
branch
from
3b09a51 to
1b9a83d
Compare
Dav1dde
force-pushed
the
dav1d/store-spans-from-transactions
branch
from
1b9a83d to
eaacc0f
Compare
loewenheim
reviewed
May 29, 2026
loewenheim
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of bolting
extracted_spansonto the transaction, it is now modeled as a separate type with its own workflow and rate limiting. This simplifies control flow a bit, but it does make metric extraction slightly trickier (see comments in code).This solves a longstanding issue where we serialized spans just to de-serialize them again in the store. This is also the first step to no longer sending envelopes to the store.
Also includes some tiny refactors moving files/structs around to make the code base easier to navigate.
Refs: INGEST-644