feat(ProjectList) My Projects - #81
Closed
sergical wants to merge 1 commit into
Closed
Conversation
Comment on lines
+478
to
+479
| group={{id: project.group, ...groupsList[project.group]}} | ||
| submissionsClosed={submissionsClosed} |
There was a problem hiding this comment.
Potential bug: Spreading `groupsList[project.group]` can cause a TypeError if a project has no group, as `...undefined` is not allowed. This will crash the component.
- Description: When rendering the project list, if a project's
groupproperty isundefined,null, or an empty string, the expressiongroupsList[project.group]will evaluate toundefined. The code then attempts to spread thisundefinedvalue inside an object literal ({...groupsList[project.group]}). This operation throws aTypeError: undefined is not iterable, which will cause the React component to crash and prevent the project list from rendering for the user. Evidence fromNewProject.jsandEditProject.jsconfirms that projects can exist without an assigned group. - Suggested fix: Provide a fallback empty object to prevent the spread operator from receiving
undefined. Change...groupsList[project.group]to...(groupsList[project.group] || {}). This ensures that if the lookup fails, an empty object is spread, which is a safe no-op.
severity: 0.7, confidence: 0.95
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my projects