Skip to content

Send deviceid with formList requests#7181

Merged
grzesiek2010 merged 6 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7062
May 8, 2026
Merged

Send deviceid with formList requests#7181
grzesiek2010 merged 6 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7062

Conversation

@grzesiek2010
Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 commented Apr 15, 2026

Closes #7062

Why is this the best possible solution? Were any other approaches considered?

Not much to discuss here, as this is what we already did for one of our forks.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This change modifies the URL used to download forms, so we need to perform regression testing for form downloads, including forms with media files, entities, and form updates.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review April 15, 2026 12:33
@grzesiek2010 grzesiek2010 requested a review from seadowg April 21, 2026 06:52
@grzesiek2010 grzesiek2010 requested a review from seadowg April 30, 2026 13:48
Comment thread entities/src/main/java/org/odk/collect/entities/javarosa/parse/StringExt.kt Outdated
@grzesiek2010 grzesiek2010 merged commit 5b15b82 into getodk:master May 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send deviceid with formList requests

2 participants