fix: report an invalid syndicator URL instead of throwing - #931
Merged
Merged
Conversation
Reading a Mastodon or Bluesky syndicator’s info threw on an invalid URL, which failed every Micropub create, the config query and the post form. Report it through info.error, as a missing username already is, and make the endpoints that read info tolerate a target that still throws. Fixes #930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #930.
syndicator-mastodonandsyndicator-bluesky:inforeturnserror: "Valid server URL required"/"Valid profile URL required"for an unparseable URL, alongsidecheckedandservice, instead of throwingTypeError: Invalid URL.endpoint-micropub:getConfigleaves out a target whoseinfothrows;getSyndicateToPropertyskips it. Guards for third-party syndicators that still throw.endpoint-posts:getSyndicateToItemsshows such a target disabled with the error message as its hint, using the plug-in’snameas label.infois now read once per target.TypeError: Invalid URLin the syndicators, an uncaught throw in the consumers).Verified locally: syndicator-mastodon 38/38, syndicator-bluesky 40/40, endpoint-micropub 148/148, endpoint-posts 33/33; eslint and prettier clean.