Repository navigation
fix(endpoint-posts): use correct template variable for syndicate form source_url - #876
Merged
Merged
Conversation
… source_url The syndicate form button was using `data.url` for the source_url value, but `data` is never set in the template context. The post controller and middleware set `properties` (via response.locals.properties), not `data`. This caused the syndicate form to submit with an undefined source_url, which made the syndicate endpoint fall back to finding "the most recently published post awaiting syndication" instead of syndicating the post the user was actually viewing. The fix changes `data.url` to `properties.url` to correctly reference the post URL from the template context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitting an original fix by @rmdes included as part of #828.
The syndicate form button was using
data.urlfor the source_url value, butdatais never set in the template context. The post controller and middleware setproperties(via response.locals.properties), notdata.This caused the syndicate form to submit with an undefined source_url, which made the syndicate endpoint fall back to finding "the most recently published post awaiting syndication" instead of syndicating the post the user was actually viewing.
The fix changes
data.urltoproperties.urlto correctly reference the post URL from the template context.