Skip to content

fix #12044: fix wfs layer hidden in 3D + scale arrow not rendering #12155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MV88 merged 6 commits into from
Mar 31, 2026
Merged

fix #12044: fix wfs layer hidden in 3D + scale arrow not rendering #12155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1df2889
fix #12044: fix wfs layer hidden in 3D + scale arrow not rendering
mahmoudadel54 Mar 25, 2026
6157b47
- Fix: Arrow UI disappears when zooming out in 3D styler view
mahmoudadel54 Mar 25, 2026
cc6d8f7
- fix the scale limit filter to exclude max value and include min sca…
mahmoudadel54 Mar 26, 2026
a1afdc0
- for 3D, ehnace getMapScaleForCesium to take camera prependicular po…
mahmoudadel54 Mar 27, 2026
8d0c3b2
- fix FE unit test
mahmoudadel54 Mar 27, 2026
6ce2ad1
- add unit tests for getMapScaleForCesium and isCameraPerpendicularTo…
mahmoudadel54 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion web/client/components/map/cesium/plugins/WFSLayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ const createLayer = (options, map) => {
id: options?.id,
map: map,
opacity: options.opacity,
queryable: options.queryable === undefined || options.queryable
queryable: options.queryable === undefined || options.queryable,
styleRules: options?.style?.body?.rules || []
});
let loader;
let loadingBbox;
Expand Down Expand Up @@ -187,6 +188,11 @@ Layers.registerType('wfs', {
return createLayer(newOptions, map);
}
if (layer?.styledFeatures && !isEqual(newOptions.style, oldOptions.style)) {
// update style rules here
if (!isEqual(newOptions?.style?.body?.rules, oldOptions?.style?.body?.rules)) {
let styleRules = newOptions?.style?.body?.rules || [];
layer.styledFeatures._setStyleRules(styleRules);
}
layerToGeoStylerStyle(newOptions)
.then((style) => {
getStyle(applyDefaultStyleToVectorLayer({
Expand Down
13 changes: 8 additions & 5 deletions web/client/plugins/styleeditor/VectorStyleEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { classifyGeoJSON, availableMethods } from '../../api/GeoJSONClassificati
import { getLayerJSONFeature } from '../../observables/wfs';
import { connect } from 'react-redux';
import { createSelector } from 'reselect';
import { scalesSelector } from '../../selectors/map';
import { currentZoomLevelSelector, scalesSelector } from '../../selectors/map';

const { getColors } = SLDService;

Expand Down Expand Up @@ -88,7 +88,8 @@ function VectorStyleEditor({
'Brush Script MT'
],
onUpdateNode = () => {},
scales = []
scales = [],
zoom = 0
}) {

const request = capabilitiesRequest[layer?.type];
Expand Down Expand Up @@ -258,12 +259,14 @@ function VectorStyleEditor({
supportedSymbolizerMenuOptions: ['Simple', 'Extrusion', 'Classification'],
fonts,
enableFieldExpression: ['vector', 'wfs'].includes(layer.type),
scales
scales,
zoom // passing this for showing arrow of current scale for ScaleDenominator
}}
/>
);
}
const ConnectedVectorStyleEditor = connect(createSelector([scalesSelector], (scales) => ({
scales: scales.map(scale => Math.round(scale))
const ConnectedVectorStyleEditor = connect(createSelector([scalesSelector, currentZoomLevelSelector], (scales, zoom) => ({
scales: scales.map(scale => Math.round(scale)),
zoom
})))(VectorStyleEditor);
export default ConnectedVectorStyleEditor;
Loading