Add bundled_proj_sqlite feature to support windows-msvc#245
Add bundled_proj_sqlite feature to support windows-msvc#245yutannihilation wants to merge 10 commits intogeorust:mainfrom
Conversation
|
If I skip the test case, I still see If I run the test case solely, it runs normally (and fails with a normal error). |
|
It seems above was a real bug that affects all platforms, not only Windows.I pushed the fix, but I'm happy to create a separate pull request. |
I think pulling it out would be useful. It might be useful to combine it with the ASAN PR? |
This reverts commit 1c9bc45.
|
Thanks, I removed the commit from this pull request and pushed to #246 |
|
I don't personally have a way to test this, but it seems reasonable. Any concerns @urschrei? |
|
Same re: testing, but I'm happy! Sorry we let this slide @yutannihilation. |
|
No hurry at all! I understand it's tricky to review the code that works on platforms that you don't use. Please let me know if there's anything I can help. |
CHANGES.mdorCHANGELOG.mdIn order to make proj-sys work on Windows (more specifically,
windows-msvc. I don't know well aboutwindows-gnu), I found there are at least two options.(I don't describe the details about first option, but here's what it looks like: MIERUNE/point-tiler#64)
For the second option, the proj crate and proj-sys crate already exposes
bundled_proj, but I found it's not enough on Windows' case, where we usually doesn't have SQLite installed. So, this pull request adds a feature flagbundled_proj_sqliteto expose the libsqlite3-sys'sbundledfeature in order to bundle SQLite as well.That's all of this pull request, but I have to explain about some tricky things:
bundled_proj_sqlite, we need to install SQLite on the GHA CI.cargo testrequires some Windows system libraries, otherwise it fails with the following error. So, I added these inbuild.rs.The(fixed now)proj::test::test_inverse_projectiontest reliably fails withSTATUS_ACCESS_VIOLATION. I'm yet to figure out what this error is.