[v6] migrate most CCLabelBMFont usage to geode::Label - #2185
Open
Fleeym wants to merge 1 commit into
Open
Conversation
dankmeme01
reviewed
Sep 10, 2026
dankmeme01
reviewed
Sep 10, 2026
dankmeme01
approved these changes
Sep 10, 2026
Tried to not just find & replace, I attempted to optimize create() and setString() usage wherever I could. This obviously will lead to some API breaks, so I'm basing it on v6. I think this is the full list: - `SettingNodeV3::getNameLabel()`: changed return type - `SettingNodeV3::getStatusLabel()`: changed return type - `IconButtonSprite::getLabel()`: changed return type - `Notification::getLabel()`: changed return type - `Popup::m_title`: is now Label - `ProgressBar::getProgressLabel()`: changed return type - `SelectList::m_label`: is now Label - `SliderNode::linkLabel()`: requires geode::Label for 1st param - `SliderNode::getLinkedLabel()`: changed return type - `SimpleTextArea::getLines()`: returns vector<Label*> Most should not be issues for most devs, besides Popup, SliderNode and SelectList.
Fleeym
force-pushed
the
feat/v6-label-migration
branch
from
September 10, 2026 20:07
f6f69c3 to
be1e5a7
Compare
Member
Author
|
Also updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to not just find & replace, I attempted to optimize create() and setString() usage wherever I could.
This obviously will lead to some API breaks, so I'm basing it on v6.
I think this is the full list:
SettingNodeV3::getNameLabel(): changed return typeSettingNodeV3::getStatusLabel(): changed return typeIconButtonSprite::getLabel(): changed return typeNotification::getLabel(): changed return typePopup::m_title: is nowgeode::LabelProgressBar::getProgressLabel(): changed return typeSelectList::m_label: is nowgeode::LabelSliderNode::linkLabel(): requiresgeode::Labelfor 1st paramSliderNode::getLinkedLabel(): changed return typeSimpleTextArea::getLines(): returnsvector<Label*>The majority of those should not be issues for most devs, besides Popup, SliderNode and SelectList.