Skip to content

make total update progress bar remember the size it started with so that it doesnt jump back every time a mod finishes updating #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miskkaaa wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

make total update progress bar remember the size it started with so that it doesnt jump back every time a mod finishes updating #2182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions loader/src/ui/mods/ModsLayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,15 +231,24 @@ void ModsStatusNode::updateState() {

case DownloadState::SomeDownloading: {
size_t totalProgress = 0;
size_t totalDownloading = 0;
// size_t totalDownloading = 0;

for (auto& download : downloads) {
auto status = download.getStatus();
/*
if (auto loading = std::get_if<server::DownloadStatusDownloading>(&status)) {
totalProgress += loading->percentage;
totalDownloading += 1;
}
*/
if (std::holds_alternative<server::DownloadStatusDone>(status)) {
totalProgress += 100;
} else if (auto downloading = std::get_if<server::DownloadStatusDownloading>(&status)) {
totalProgress += downloading->percentage;
}
}
auto percentage = totalProgress / static_cast<float>(totalDownloading);
auto totalDownloads = downloads.size();
auto percentage = totalProgress / static_cast<float>(totalDownloads);

m_statusPercentage->setString(fmt::format("{}%", static_cast<size_t>(percentage)).c_str());
m_statusPercentage->setVisible(true);
Expand Down