Add createWithButtonSprite function to geode::Button - #2180
Open
xblazegmd wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
Also idk what the |
Contributor
Contributor
Author
|
Bruh why does only 1 specific overload of Anyways tysm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Instead of having to manually make a
ButtonSpriteand passing that toButton::createWithNode, why not just have a helper that can make that?Now you can easily make one with
createWithButtonSprite:And if you need to change anything on it (let's say, the font/background sprite) you can do that too:
This should work perfectly fine for 99% of cases, but I'm open to feedback on what I can change