Repository navigation
PB-2315: fix readiness check - #patch - #107
Merged
Merged
Conversation
The WMS backend now returns the MapServer message wrapped in HTML, causing the exact-string equality check to fail and WMTS pods to remain unready. Replace the equality check against `wms_ok_string` with a substring search for the marker without trailing newline, and decode with `errors='replace'` to avoid failures on unexpected bytes. Add unit tests for the ready (mocked happy path) and missing-marker (503) cases.
github-actions
Bot
changed the title
faselm
approved these changes
Jun 17, 2026
ltshb
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WMS backend now returns the MapServer message wrapped in HTML, causing the exact-string equality check to fail and WMTS pods to remain unready.
Replace the equality check against
wms_ok_stringwith a substring search for the marker without trailing newline, and decode witherrors='replace'to avoid failures on unexpected bytes.Add unit tests for the ready (mocked happy path) and missing-marker (503) cases.