Adopt ExpressionTableOperations for value-expression-backed model operations#63
Open
ritchiecarroll wants to merge 3 commits into
Open
Adopt ExpressionTableOperations for value-expression-backed model operations#63ritchiecarroll wants to merge 3 commits into
ritchiecarroll wants to merge 3 commits into
Conversation
ritchiecarroll
changed the base branch from
updated-event-details-ops
to
development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consumer-side update for the
TableOperations<T>refactor inGemstone.Data. The baseTableOperations<T>is now a pure POCO operator that honors only[DefaultValue]; evaluation of attribute-based value expressions (DefaultValueExpressionAttribute/UpdateValueExpressionAttribute) is now opt-in via the newExpressionTableOperations<T>.Changes
Migrated the modeled-table call sites whose models rely on value expressions from
TableOperations<...>toExpressionTableOperations<...>, preserving current behavior end-to-end:Adapters/IndependentAdapterManagerExtensions.cs(DeviceRecord,MeasurementRecord,HistorianRecord,SignalTypeRecord,PhasorRecord)Adapters/IndependentActionAdapterManagerBase.cs(DeviceRecord)Model/DeviceExpressionParser.cs(Device)Model/MeasurementExpressionParser.cs(Measurement)Verification
Gemstone.Timeseriesbuilds clean (0 errors) against the localGemstone.Dataproject reference (Development configuration).Related PRs
TableOperations<T>refactor (required by this change)🤖 Generated with Claude Code