fix: remove forced PlateCarree projection in add_layer issue (#2730)#2828
Open
alepr wants to merge 1 commit into
Open
fix: remove forced PlateCarree projection in add_layer issue (#2730)#2828alepr wants to merge 1 commit into
alepr wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates geemap/cartoee.py to support custom map projections by passing the projection (proj) through kwargs from get_map to add_layer. In add_layer, the projection is retrieved and used as the transform parameter. The feedback suggests a more idiomatic Python approach using kwargs.get() to simplify the projection retrieval logic.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+154
to
+157
| if "proj" in kwargs: | ||
| proj = kwargs["proj"] | ||
| else: | ||
| proj = ccrs.PlateCarree() |
Contributor
2e5fc31 to
4499fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the
add_layerfunction forcedccrs.PlateCarree()by default, causing rendering errors when using custom projections. Fixes #2730Changes
ccrs.PlateCarree()coordinate system inax.imshow().Testing