feat(apis/vara-eth): add support for uploading codes in EIP-7594 format#2405
Merged
StackOverflowExcept1on merged 21 commits intomainfrom Apr 2, 2026
Merged
feat(apis/vara-eth): add support for uploading codes in EIP-7594 format#2405StackOverflowExcept1on merged 21 commits intomainfrom
StackOverflowExcept1on merged 21 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements code validation functionality, including a new frontend upload feature and updates to the RouterClient to support EIP-4844 transactions. Key changes involve adding the UploadCodeButton component, the useUploadCode hook, and updating the viem dependency to a specific PR build across multiple packages. Review feedback focuses on the risks of using non-standard dependency versions and wildcard peer dependencies, a potential race condition in the frontend transaction logic, and the importance of maintaining a pinned Rust toolchain for build reproducibility. Suggestions were also made to improve error handling and avoid hardcoding transaction parameters.
osipov-mit
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works in
apis/vara-ethand passes all tests. It also fixes the blob codec to support codes larger than 128 KiB (this is AI-generated code, so it would be nice to test it).Currently, this fix in
apis/vara-ethrelies on wevm/viem#4022. I forkedviemhere and resolved all merge conflicts: https://github.com/StackOverflowExcept1on/viem/tree/feat/eip-7594-support-for-blob-txs. It would be nice to create our own package like@vara-eth/viemand use it everywhere instead of the current fork.As for the frontend, since
apis/vara-ethuseskzg-wasm, we need to load this.wasmin the browser. It works in production builds, but is broken inyarn start(dev builds). Therefore, I addedserveKzgWasmFromViteCachePathas a temporary solution.kzg-wasmalso doesn't work well withnodePolyfills(): ethereumjs/kzg-wasm#28, so I disabledprocessinnodePolyfills(). This is also a temporary solution, so we need to somehow make the frontend configs configurable.There is also an issue that MetaMask currently doesn't support EIP-4844 transactions: MetaMask/core#8331. I think we could solve this based on this context: