Sanitize TARGET_BLOB_NAME_TAG values on Azure#994
Open
miselin wants to merge 1 commit intogaul:masterfrom
Open
Sanitize TARGET_BLOB_NAME_TAG values on Azure#994miselin wants to merge 1 commit intogaul:masterfrom
miselin wants to merge 1 commit intogaul:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blob names have a wider set of permitted characters than tag values, so it's possible for the target blob name tag to cause an error even though the blob itself will create successfully.
This will now base64-encode the blob name to ensure it's always writable.
This would be a smaller patch, but I wanted to ensure there are two backwards-compatible safeties:
Tested via
mvn test, and by running a custom build in production to confirm the fix works.