Verify per-chunk signatures for STREAMING-AWS4-HMAC-SHA256-PAYLOAD#1027
Merged
Verify per-chunk signatures for STREAMING-AWS4-HMAC-SHA256-PAYLOAD#1027
Conversation
Implement the chunk-signature chain from the SigV4 streaming spec:
each chunk's signature is HMAC(signingKey, "AWS4-HMAC-SHA256-PAYLOAD\n
<ts>\n<scope>\n<prevSig>\n<SHA256("")>\n<SHA256(chunk)>"), with
prevSig seeded from the Authorization header signature and chained
across chunks. Mismatches throw SignatureDoesNotMatch.
Extract deriveSigningKeyV4 from createAuthorizationSignatureV4 so the
handler can reuse it when constructing the verifying ChunkedInputStream
after authentication. Un-ignore testAwsV4SignatureChunkedSigned.
Fixes #205.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the chunk-signature chain from the SigV4 streaming spec: each chunk's signature is HMAC(signingKey, "AWS4-HMAC-SHA256-PAYLOAD\n \n\n\n<SHA256("")>\n<SHA256(chunk)>"), with prevSig seeded from the Authorization header signature and chained across chunks. Mismatches throw SignatureDoesNotMatch.
Extract deriveSigningKeyV4 from createAuthorizationSignatureV4 so the handler can reuse it when constructing the verifying ChunkedInputStream after authentication. Un-ignore testAwsV4SignatureChunkedSigned.
Fixes #205.