fix(cli): use normalize_virtually for pipe path on windows

[Sirius902]

Fixes reaching an unimplemented function in Wine when running the Windows binary of me3. I originally ran into this issue when trying to play the Windows version of Dark Souls III Archipelago v4.0.0 in my custom Wine prefix and it turns out it just needed a one line change to stop crashing on startup!

Here was the original log messages when it was crashing on startup.

 INFO launch: me3::commands::launch: monitor pipe created path="\\\\.\\pipe\\bxV-1I-6omPhnkynIMn2gw=="
 INFO launch: me3::commands::launch: created log file log_file_path="C:\\users\\steamuser\\AppData\\Local\\garyttierney\\me3\\data\\logs\\me3-config\\2026-04-15_02-27-41.log"
ERROR launch: me3::commands::launch: error=Invalid function. (os error 1)

[garyttierney]

LGTM, thanks. I'm surprised it was hitting an unimplemented stub. What version of WINE out of curiosity?

[garyttierney]

Hm, actually, looking closer at this normalize_virtually() is only supported on Windows, but if you're on Linux you're generally using the Linux executable. We can keep the normalize_virtually(), that's fine (we need to gate it behind a Windows-only cfg check though, see build failure), but it sounds like you want to be running the mod with the Linux build of the me3 CLI instead.

[Sirius902]

Alrighty, I've updated the PR to fix the Linux build failure and the DCO CI check.

LGTM, thanks. I'm surprised it was hitting an unimplemented stub. What version of WINE out of curiosity?

I think this may be something to do with the fact that it's normalizing the path of a pipe specifically but I'm not sure. I'm using the soda-9.0-1 runner (based on Wine 9 with Valve's Proton patches and extras) in Bottles. Running the wine64 --version of this runner gives this specific version string.

wine-experimental.bleeding.edge.9.0.93696.20240429 ( TkG Plain )

Hm, actually, looking closer at this normalize_virtually() is only supported on Windows, but if you're on Linux you're generally using the Linux executable. We can keep the normalize_virtually(), that's fine (we need to gate it behind a Windows-only cfg check though, see build failure), but it sounds like you want to be running the mod with the Linux build of the me3 CLI instead.

For my current setup I had thought to use Bottles with networking disabled so I could be 100% confident my modded setups wouldn't attempt to connect to the game server. I share this setup for DSAP and Dark Souls II Archipelago as well so I naturally thought to run the Windows version of me3 under Wine as well. It seems me3 has a feature to prevent connecting online by default so maybe using the Linux binary could be interesting but one blocker is I'm running on NixOS so I don't think the me3 Linux binary would work out of the box.

I could try to make a Nix package for me3 and possibly upstream to nixpkgs if there's interest, though, I think it is worth supporting both use cases if possible without too much effort. For me right now running the Windows version of me3 in Wine is easier but I think making a Nix package might be worth exploring.

[garyttierney]

Alrighty, I've updated the PR to fix the Linux build failure and the DCO CI check.

Thanks! LGTM. Waiting on CI then will merge.

I could try to make a Nix package for me3 and possibly upstream to nixpkgs if there's interest, though, I think it is worth supporting both use cases if possible without too much effort. For me right now running the Windows version of me3 in Wine is easier but I think making a Nix package might be worth exploring.

FWIW, me3 is in nixpkgs upstream as of about a week ago: NixOS/nixpkgs#498117.