Skip to content

docs(charts): correct identity chart deprecation notice#2963

Open
petersutter wants to merge 2 commits into
masterfrom
fix/identity-chart-deprecation-notice
Open

docs(charts): correct identity chart deprecation notice#2963
petersutter wants to merge 2 commits into
masterfrom
fix/identity-chart-deprecation-notice

Conversation

@petersutter
Copy link
Copy Markdown
Member

@petersutter petersutter commented May 12, 2026

How to categorize this PR?
/area documentation
/kind cleanup

What this PR does / why we need it:

Corrects the deprecation notice in the identity Helm chart README. The identity chart is removed without replacement, not migrated to gardener-operator.

Which issue(s) this PR fixes:
Ref #2935

Special notes for your reviewer:

Release note:

NONE

Summary by CodeRabbit

  • Documentation
    • Updated deprecation notice for the identity chart: clarified removal timeline to around November 2026 and removed prior migration guidance.
    • Updated deprecation callout for the dashboard chart to a CAUTION-style notice and adjusted wording to state removal earliest around November 2026.

Review Change Stack

The identity chart is removed without replacement, not migrated
to gardener-operator. Remove misleading migration guidance.
@gardener-prow gardener-prow Bot added area/documentation Documentation related kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 12, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign klocke-io for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bdf2bca8-e895-4320-b2e6-414ee1b77734

📥 Commits

Reviewing files that changed from the base of the PR and between bb23892 and 6f255a4.

📒 Files selected for processing (2)
  • charts/gardener-dashboard/README.md
  • charts/identity/README.md
✅ Files skipped from review due to trivial changes (2)
  • charts/gardener-dashboard/README.md
  • charts/identity/README.md

📝 Walkthrough

Walkthrough

Update deprecation callouts in two Helm chart READMEs: adjust removal timeline wording in charts/gardener-dashboard/README.md and mark the charts/identity/README.md removal as “without replacement” with an approximate date of around November 2026.

Changes

Chart README deprecation edits

Layer / File(s) Summary
Deprecation callout wording updates
charts/gardener-dashboard/README.md, charts/identity/README.md
Changed deprecation/removal phrasing: dashboard README timeline wording adjusted to "removed earliest around November 2026"; identity README now states removal "without replacement" and an approximate "around November 2026", removing prior migration guidance.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

size/S

Suggested reviewers

  • holgerkoser
  • grolu
  • klocke-io

Poem

🐰 A small edit I brought to light,
Two READMEs trimmed to fit just right,
Dates and wording now concise and clear,
November whispers, the end is near 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: correcting the identity chart deprecation notice in documentation.
Description check ✅ Passed The PR description follows the template structure with categorization, clear explanation of changes, issue reference, and appropriate release note.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/identity-chart-deprecation-notice

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@charts/identity/README.md`:
- Line 5: The sentence "It will be removed without replacement earliest 6 months
after deprecation (around November 2026)." is awkward; update that sentence to
clarify the earliest-removal constraint and expected month, e.g. rephrase to "It
will be removed no earlier than six months after deprecation (approximately
November 2026)." Replace the existing sentence with the clearer wording to make
the timeline explicit and readable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3bdabb52-c4c2-4efe-b607-9fd99e1af889

📥 Commits

Reviewing files that changed from the base of the PR and between f584931 and bb23892.

📒 Files selected for processing (1)
  • charts/identity/README.md

Comment thread charts/identity/README.md Outdated
Replace awkward "earliest 6 months after deprecation (around November
2026)" with concise "earliest around November 2026".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Documentation related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant