docs(charts): correct identity chart deprecation notice#2963
docs(charts): correct identity chart deprecation notice#2963petersutter wants to merge 2 commits into
Conversation
The identity chart is removed without replacement, not migrated to gardener-operator. Remove misleading migration guidance.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughUpdate deprecation callouts in two Helm chart READMEs: adjust removal timeline wording in ChangesChart README deprecation edits
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/identity/README.md`:
- Line 5: The sentence "It will be removed without replacement earliest 6 months
after deprecation (around November 2026)." is awkward; update that sentence to
clarify the earliest-removal constraint and expected month, e.g. rephrase to "It
will be removed no earlier than six months after deprecation (approximately
November 2026)." Replace the existing sentence with the clearer wording to make
the timeline explicit and readable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Replace awkward "earliest 6 months after deprecation (around November 2026)" with concise "earliest around November 2026".
How to categorize this PR?
/area documentation
/kind cleanup
What this PR does / why we need it:
Corrects the deprecation notice in the
identityHelm chart README. The identity chart is removed without replacement, not migrated to gardener-operator.Which issue(s) this PR fixes:
Ref #2935
Special notes for your reviewer:
Release note:
Summary by CodeRabbit