Skip to content

Feature hide elements of NewShoot dialogue#2478

Open
benedikt-haug wants to merge 12 commits into
gardener:masterfrom
benedikt-haug:feature_hide_elements
Open

Feature hide elements of NewShoot dialogue#2478
benedikt-haug wants to merge 12 commits into
gardener:masterfrom
benedikt-haug:feature_hide_elements

Conversation

@benedikt-haug
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR is part of the Hackaton.
This PR allows the operator to hide elements of the NewShoot dialogue.

Without configuring anything, nothing should change. The end-result might be:
grafik

Special notes for your reviewer:
/cc @marc1404 @klocke-io

Release note:

Allow hiding parts of the newShoot dialogue

@ghost
Copy link
Copy Markdown

ghost commented Jun 5, 2025

@benedikt-haug Thank you for your contribution.

@ghost ghost added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2025
@gardener-robot-ci-1
Copy link
Copy Markdown
Contributor

Thank you @benedikt-haug for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@klocke-io klocke-io added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 5, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 5, 2025
Copy link
Copy Markdown
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes sense together with PR #2476, however, I do not get the complete story. Is the goal to avoid overwhelming users when creating shoots and to control certain defaults (some of which cannot be changed after shoot creation), while giving users the freedom to change other settings later on (like hibernation, DNS config, addons, auto update)?

If there are CloudProfiles from different providers, I can change the infrastructure in the YAML tab. But this makes it confusing. Also you can create credentials for the infrastructure provider but you cannot select / change the infrastructure provider on the creation dialog. Or is the idea/recommendation to hide the infrastructure option only in landscapes where there is no other provider type?

Comment thread charts/gardener-dashboard/values.yaml Outdated
@benedikt-haug
Copy link
Copy Markdown
Contributor Author

This PR makes sense together with PR #2476, however, I do not get the complete story. Is the goal to avoid overwhelming users when creating shoots and to control certain defaults (some of which cannot be changed after shoot creation), while giving users the freedom to change other settings later on (like hibernation, DNS config, addons, auto update)?
If there are CloudProfiles from different providers, I can change the infrastructure in the YAML tab. But this makes it confusing. Also you can create credentials for the infrastructure provider but you cannot select / change the infrastructure provider on the creation dialog. Or is the idea/recommendation to hide the infrastructure option only in landscapes where there is no other provider type?

The goals of this PR is for the operator to be able to gain by configuration:

  • free screen real estate if no choice is possible e.g. hide infrastructure section if only a single cloud provider exists or if choosing non-default isn't economically sensible
  • nudge novice users e.g. if high-availability is the configured default (possible by the other PR), disabling this is generally not intended by the cluster operator, thus hiding this section reduces potential for user errors
  • save explanation effort by hiding advanced usecases e.g. addons which aren't actually supported for production or workerless clusters which are mainly useful for development purposes

@ghost
Copy link
Copy Markdown

ghost commented Jun 8, 2025

@holgerkoser, @grolu, @klocke-io You have pull request review open invite, please check

@ghost ghost added the needs/rebase Needs git rebase label Oct 16, 2025
@ghost
Copy link
Copy Markdown

ghost commented Oct 16, 2025

@benedikt-haug You need rebase this pull request with latest master branch. Please check.

@grolu grolu added area/ipcei IPCEI (Important Project of Common European Interest) and removed area/ipcei IPCEI (Important Project of Common European Interest) labels Dec 1, 2025
@ghost ghost added the status/accepted Issue was accepted as something we need to work on label Jan 11, 2026
@benedikt-haug
Copy link
Copy Markdown
Contributor Author

/remove-lifecycle rotten

@ghost
Copy link
Copy Markdown

ghost commented Jan 11, 2026

@benedikt-haug Command /remove-lifecycle is not known.

@grolu grolu removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 12, 2026
@gardener-ci-robot
Copy link
Copy Markdown
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as active with /lifecycle active
  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 11, 2026
@gardener-ci-robot
Copy link
Copy Markdown
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as active with /lifecycle active
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close

/lifecycle rotten

@gardener-prow gardener-prow Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 13, 2026
@gardener-ci-robot
Copy link
Copy Markdown
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as active with /lifecycle active
  • Mark this PR as fresh with /remove-lifecycle rotten

/close

@gardener-prow gardener-prow Bot closed this Mar 27, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Mar 27, 2026

@gardener-ci-robot: Closed this PR.

Details

In response to this:

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as active with /lifecycle active
  • Mark this PR as fresh with /remove-lifecycle rotten

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@grolu grolu reopened this May 13, 2026
@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 13, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow Bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label May 13, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 13, 2026

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grolu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2026
@grolu grolu added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 13, 2026
@gardener-prow gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 13, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/accepted Issue was accepted as something we need to work on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants