Changes to stabilizer calculations and permreps in automorphism groups - #6494
Open
hulpke wants to merge 5 commits into
Open
Changes to stabilizer calculations and permreps in automorphism groups#6494hulpke wants to merge 5 commits into
hulpke wants to merge 5 commits into
Conversation
hulpke
added
kind: enhancement
When computing the permutation representation of an automorphism group, avoid being dragged into a special case for abelian groups. Use `SubnormalOrbitExtension` to speed up a stabilizer calculation. Call the function directly, before trying to fit it more generally in the method selection.
to compute an orbit along a composition series also in a nonsolvable group.
avoid some membership tests and transfer group orders
For two-generator groups, isomorphism test will use old routine if only few possible images. Automorphism groups of abelian groups will know their order.
hulpke
added
topic: performance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6494 +/- ##
==========================================
- Coverage 79.03% 70.92% -8.12%
==========================================
Files 685 683 -2
Lines 293802 292998 -804
Branches 8664 8611 -53
==========================================
- Hits 232219 207815 -24404
- Misses 59782 83278 +23496
- Partials 1801 1905 +104 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes resolve memory use and sluggishness issues being brought up in #6478. This is done by reducing over cautious effort in computing a permutation representation, and by using a new stabilizer routine that works along a composition series, mirrorign what the pc algorithm does. It also will try replacing a large orbit buildup with specific element tests to save on memory.
Also added special handling of 2-generator groups, which might refer back to the old routine if there are few images.