Make smallgrp an explicit dependency - #52
Open
fingolfin wants to merge 1 commit into
Open
Conversation
LocalNR uses SmallGroup and IdGroup in lib/lib_local.gi to construct and
to identify the additive groups of the local near-rings in its library,
so it needs the SmallGrp package. Without it, loading LocalNR in a GAP
started with `--bare` and running its tests failed with
Error, the Small Groups library is required but not installed
At the moment this happens to be masked once SONATA declares smallgrp as
a needed package, but relying on that is fragile, and LocalNR uses these
functions in its own code.
See gap-system/gap#2434
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 4 4
Lines 464 464
=======================================
Hits 447 447
Misses 17 17 🚀 New features to boost your workflow:
|
Member
Author
|
@IrynaRaievska @raemarina @olexandr-konovalov hope this can be put into a release soon. happy to do it for you as well, but did not want to do this "behind your backs" :-) |
olexandr-konovalov
approved these changes
Aug 10, 2026
olexandr-konovalov
left a comment
Member
There was a problem hiding this comment.
@fingolfin thanks, sure thing! Will wait till @raemarina & @IrynaRaievska confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalNR uses
SmallGroupandIdGroupinlib/lib_local.gi(lines 21, 71, 177, 219, 248) to construct and to identify the additive groups of the local near-rings in its library, but the SmallGrp package is not declared as a dependency. Running the test suite in a GAP where SmallGrp is not loaded therefore fails:This adds
["smallgrp", ">= 1.3"]toNeededOtherPackages.Note that the failure is currently masked as soon as SONATA declares smallgrp as a needed package (see https://github.com/gap-packages/sonata), since LocalNR needs SONATA. Relying on a transitive dependency is fragile though, and LocalNR calls these functions in its own code, so it should declare the dependency itself.
Testing
gap --bare -c 'LoadPackage("GAPDoc");'+LoadPackage("localnr" : OnlyNeeded)+TestPackage("localnr")— 0 failures in 2 files.The version in
PackageInfo.gis untouched, so this needs a version bump and release on your side.Context
This comes out of gap-system/gap#2434, which aims to make GAP and its packages work when PrimGrp/SmallGrp/TransGrp are not installed. LocalNR showed up in a PackageDistro CI experiment running package test suites under
gap --bare.🤖 Generated with Claude Code