Avoid dependency on the SmallGrp package - #30
Merged
Merged
Conversation
HeLP used `CharacterTable(SmallGroup(1,1))` as the initial value of the global variable `HeLP_CT`, once at load time and once in `HeLP_Reset`. The load time use means HeLP cannot even be loaded when the SmallGrp package is not available, e.g. in a GAP started with `--bare`. `SmallGroup(1,1)` is just the trivial group, so use `TrivialGroup()` instead; it likewise is a pc group, and the resulting character tables agree on `Irr`, `OrdersClassRepresentatives` and `ClassNames`. With this, HeLP no longer uses any function from SmallGrp, PrimGrp or TransGrp. See gap-system/gap#2434 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 67.91% 67.91%
=======================================
Files 7 7
Lines 2537 2537
=======================================
Hits 1723 1723
Misses 814 814
🚀 New features to boost your workflow:
|
Member
Author
|
@margollo would be great to have this in a new package release :-) |
Collaborator
|
Will be included, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeLP uses
CharacterTable(SmallGroup(1,1))as the initial value of the global variableHeLP_CT, in two places:lib/HeLP_internal_no_solving.gi:5, which is executed at load timelib/HeLP_no_solving.gi:54, insideHeLP_ResetBecause of the first one, HeLP cannot even be loaded when the SmallGrp package is unavailable:
SmallGroup(1,1)is just the trivial group, so this replaces both uses withTrivialGroup(). That is likewise a pc group, and the two character tables agree onIrr,OrdersClassRepresentativesandClassNames. The documentation ofHeLP_Resetis updated accordingly.With this change HeLP no longer uses any function from SmallGrp, PrimGrp or TransGrp.
Testing
gap --bare -c 'LoadPackage("GAPDoc");'+LoadPackage("help" : OnlyNeeded)+TestPackage("help")— now passes; previously failed at load.HeLP_Resetadditionally exercised by hand; it is also covered bytst/no_solver.tst.Context
This comes out of gap-system/gap#2434, which aims to make GAP and its packages work when PrimGrp/SmallGrp/TransGrp are not installed. HeLP showed up in a PackageDistro CI experiment that runs package test suites under
gap --bare.🤖 Generated with Claude Code