Skip to content

Fix CER loading#410

Open
AreWeDreaming wants to merge 4 commits into
masterfrom
fix_CER_loading
Open

Fix CER loading#410
AreWeDreaming wants to merge 4 commits into
masterfrom
fix_CER_loading

Conversation

@AreWeDreaming
Copy link
Copy Markdown
Collaborator

Description

The problem with the CER data load is that the ION.IMPDENS tree nodes actually point into a different MDSPlus tree (IMPCON01 and IMPCON02). In getMany that means that as soon as you hit the first IMPDENS node you close the ION tree and then never open in again.

The new code now queries to where the IMPDENS nodes are actually pointing and then use regex to formulate an updated query against which ever IMPCON flavor was linked in a separate step which resolves the switching.

The resulting fetched data does not agree with imas_composer, but in the spirit of making more PRs that are smaller I would like to track that issue separately.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

Pre-Merge Checklist

  • OMFIT has been tested with this OMAS version and you will create a PR on OMFIT that updates the OMAS submodule once this has been merged.
  • Version number has been incremented if this is a major modification or important bug fix
    • To increment the version: Edit the version number in omas/version file
    • Follow semantic versioning: MAJOR.MINOR.PATCH (e.g., 0.94.20.94.3 for bug fixes, 0.94.20.95.0 for new features)
    • A GitHub release will be automatically created when this PR is merged if the version number has changed

Additional Notes

-  This prevents MDSplus from closing the IONS tree on you
- Some light refactoring of omas_mds to allow `getnci` to be executed outside of mdsvalue
@AreWeDreaming AreWeDreaming requested a review from torrinba May 20, 2026 01:10
Comment thread omas/utilities/omas_mds.py Outdated
Comment thread omas/machine_mappings/d3d.py Outdated
@AreWeDreaming AreWeDreaming mentioned this pull request May 21, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants