Fix CER loading#410
Open
AreWeDreaming wants to merge 4 commits into
Open
Conversation
- This prevents MDSplus from closing the IONS tree on you - Some light refactoring of omas_mds to allow `getnci` to be executed outside of mdsvalue
torrinba
reviewed
May 20, 2026
torrinba
reviewed
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem with the CER data load is that the
ION.IMPDENStree nodes actually point into a different MDSPlus tree (IMPCON01andIMPCON02). IngetManythat means that as soon as you hit the firstIMPDENSnode you close theIONtree and then never open in again.The new code now queries to where the
IMPDENSnodes are actually pointing and then use regex to formulate an updated query against which everIMPCONflavor was linked in a separate step which resolves the switching.The resulting fetched data does not agree with imas_composer, but in the spirit of making more PRs that are smaller I would like to track that issue separately.
Type of Change
Testing
Pre-Merge Checklist
omas/versionfile0.94.2→0.94.3for bug fixes,0.94.2→0.95.0for new features)Additional Notes