Added Mute and Clear Bugs to Minimap Menu - #168
Open
Gogo1951 wants to merge 2 commits into
Open
Conversation
Did a bit of a reformat on the code too.
Author
|
"Mute On" is weird to me but I left it that way since that's how it worked in the legacy options. I think it should be "Sound On" and "Sound Off" but "Mute On" means "Sound Off" just... odd UX. On should be on, off should be off. (= |
Author
|
Doing a bit of a cleanup to get it to use standard "Info Blue" like Blizzard does other places in tooltips. 
Old 
|
Author
|
I didn't see there was a localization file. Let me work on that next. (= |
Author
|
Oof, and I never knew there was already an Alt + Click clear bugs option. Let me update that. (= The things you learn when you actually look at the Localization files. Ha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a bit of a reformat on the code too.
Fixes