Redesign Github workflows#59
Merged
Merged
Conversation
- Have a single test workflow for testing everything, including the API server. - Split the API server workflow into a build part and a deploy part. Get rid of test steps, since that's done by the test workflow. - Syntax check Ansible. - Make test and API server build workflows compatible with pull requests. - Enforce timeouts.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
abtreece
reviewed
May 15, 2026
Collaborator
abtreece
left a comment
There was a problem hiding this comment.
Solid consolidation — security posture is meaningfully better than what it replaces. A few inline notes.
Member
Author
|
Addressed all feedback. |
abtreece
approved these changes
May 15, 2026
Collaborator
abtreece
left a comment
There was a problem hiding this comment.
LGTM. Verified the three fix commits:
10f1ae72— force-push skip now recovers changed files viamerge-baseinstead of always over-building; fail-open guards on default branch and unresolvable merge-base. Nice.463a1f18—restore-keysadded.2a8bb460—-fdropped from the deploy tag push.
Accepting your calls on zizmor (blocking is the right default) and the README wording. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.