Repository navigation
Conversation
…both names manuf is tab-separated: prefix, a short name of at most 12 characters, then the full name. The parser split on any whitespace and joined everything after the prefix, so entries that only manuf supplies shipped with the short name glued to the front of the full one, for example "IntegratedTe Integrated Technical Vision Ltd". Take the full name, and the short one only when it is the whole entry. Older files put the full name in a trailing `#` comment, which is handled too. The shipped dataset still has the glued names until the generator is run again, which downloads the IEEE and Wireshark lists.
40,543 prefixes (was 38,849). Entries only Wireshark's manuf supplies now carry one name, for example 0A:35:F2 is "Integrated Technical Vision Ltd" instead of "IntegratedTe Integrated Technical Vision Ltd".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the audit's docs pass. Wireshark's
manuffile is tab-separated: prefix, a short name of at most 12 characters, then the full name. The generator split on any whitespace and glued both names together, so makers that onlymanuflists showed as "IntegratedTe Integrated Technical Vision Ltd".scripts/generate-oui.rskeeps the full name, and the short one only when it is the whole entry. A test fails on the old parser.crates/netscli-core/data/oui.min.json.gzis regenerated from today's IEEE and Wireshark lists: 40,543 prefixes, up from 38,849.Checked:
cargo testinscripts/passes,netscli-coreoui tests pass, and spot checks show 0A:35:F2 = Integrated Technical Vision Ltd and 0A:2A:33 = Digistor.