Skip to content

Don't rebuild HTTP session with no connections #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martindurant wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Don't rebuild HTTP session with no connections #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion s3fs/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ async def set_session(self, refresh=False, kwargs={}):
if self._s3 is not None and not refresh:
hsess = getattr(getattr(self._s3, "_endpoint", None), "http_session", None)
if hsess is not None:
if all(_.closed for _ in hsess._sessions.values()):
if hsess._sessions and all(_.closed for _ in hsess._sessions.values()):
refresh = True
if not refresh:
return self._s3
Expand Down
Loading