Added a mission type to adventure missions - #557
Merged
Merged
Conversation
…app to have a few different images depending on the mission type. It is not the prettiest solution but should be fine.
Contributor
Author
|
Why did the test "event signup without group" fail, I didn't touch events? |
… max number is probably unnecessary, this would be handled in the app.
Contributor
|
Would it be difficult to make it an enum instead? The number feels difficult to decode. But it's not that important since it might not be used much beyond this nollning. |
Contributor
Author
|
I changed this now to the actual categories |
georgelgeback
approved these changes
Aug 17, 2026
georgelgeback
left a comment
georgelgeback
left a comment
Contributor
There was a problem hiding this comment.
LGTM 💯! If you are OK with my bugfix and the way I merged in main, just squash and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a mission type to adventure missions. This will be used in the app to have a few different images depending on the mission type. It is not the prettiest solution but should be fine.