cpu-features: Ignore CET SS unless actively used#804
cpu-features: Ignore CET SS unless actively used#804yjugl wants to merge 2 commits intofrida:mainfrom
Conversation
f670c75 to
c0ffb99
Compare
c0ffb99 to
38418b0
Compare
|
MinGW builds are failing not finding |
oleavr
left a comment
There was a problem hiding this comment.
Thanks!! (And apologies for the delay.)
We are in control of the MinGW bits, though we're currently piggybacking on the pre-installed components on GitHub's runners to speed up CI, but we could always have it update the components as an up-front step.
However, we still want to retain support for XP -- due to users reversing software on legacy systems -- so we should resolve the function dynamically to retain backwards compatibility.
Since #791 we are ensuring a proper call-ret discipline in the x86 interceptor, if we detect that the CPU is compatible with Intel CET shadow stacks. As discussed in #791, this has an unnecessary performance cost if the mitigation is not used by the current process. This extra patch thus ignores CET shadow stacks compatibility on Windows if we detect that the current process is not using the mitigation. It might be cleaner to move this code outside
gum_do_query_cpu_features, but putting it there makes the patch very simple and atomic.