riscv support#1071
Open
wyxhjr wants to merge 1 commit intofrida:mainfrom
Open
Conversation
oleavr
requested changes
Jan 6, 2026
Member
oleavr
left a comment
oleavr
left a comment
There was a problem hiding this comment.
Thanks! 🙌 What is the current state of this? From a quick look it seems it won't compile cleanly (at least not without warnings).
| } | ||
|
|
||
| static JSValue | ||
| gum_riscv_parse_memory_operand_value (JSContext * ctx, |
Member
There was a problem hiding this comment.
This function isn't forward-declared, so this code doesn't compile cleanly (without warnings). IIRC the analogous code for V8 has the same issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support, draft stage, some issues with the interceptor need to be resolved.