Skip to content

fix: exit-for-restart on redb poison instead of bricking forever (#4604) #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanity merged 4 commits into from
Jul 1, 2026
Merged

fix: exit-for-restart on redb poison instead of bricking forever (#4604) #4609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2865f38
fix: exit-for-restart on redb poison instead of bricking forever (#4604)
sanity Jun 28, 2026
f61eee5
fix: also route read-path redb poison to recovery (#4604 review)
sanity Jun 28, 2026
76eab99
fix: route commit-time redb poison to recovery on the same op (#4604 …
sanity Jun 28, 2026
9029c0c
style: reindent read_guarded closure body + add read-path poison test…
sanity Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/core/src/bin/freenet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,15 @@ async fn run_network_node_with_signals(
freenet::enable_fast_crash_exit_code();
}

// #4604: this is the real node process, so let the contract storage layer
// exit-for-restart if redb gets poisoned by a transient I/O error (e.g. a disk
// EIO / filesystem csum failure). Without this the node stays "running" while
// every contract GET/PUT/UPDATE fails forever; with it, the supervisor restarts
// the node with a fresh database handle. The exit code reuses the fatal-listener
// decision above, so a database that re-poisons on every boot (persistent
// corruption) is bounded by the same crash-loop protection rather than looping.
freenet::enable_abort_on_redb_poison();

// #4073 crash-loop auto-rollback: once this (possibly freshly auto-updated)
// node has run healthily for the commit window, clear any post-update
// probation marker so ordinary later crashes never trigger a rollback. The
Expand Down
Loading
Loading