Repository navigation
fix: preserve QoS and precedence when applying traffic influence - #87
Merged
Alonza0314 merged 5 commits intoOct 21, 2026
Merged
Conversation
Contributor
Author
Alonza0314
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traffic Influence currently creates dynamic PCC rules with routing and optional charging data but omits
refQosData. Supply the necessary QoS reference while preserving existing service authorization and numeric precedence when applying TI routing.Handle coverage explicitly:
defQosFlowIndication: trueand keep this fallback below existing service rules and above the original default rule. A request wholly covered by one or several services needs no extra default-flow rule.Coverage includes the union of request filters and service filters, using IPv4/IPv6 prefixes, protocol, source/destination ports and direction. Existing filters' additional restrictions are retained. This does not renumber existing PCC rules or impose a total-rule-count limit. If a required precedence interval has no free value, return an error without changing cached policy.
Updates and removal:
refTcDatain an update would leave the previously supplied TI reference valid.Standards basis:
The coverage algorithm, local allocation of unused precedence and ordering of concurrent TI requests are implementation choices; these clauses do not mandate a particular CIDR algorithm or require all TI services to use default QoS. PCF does not select numeric QFIs.
Scope and integration limits:
defQosFlowIndicationand correctly construct its marking QER. Complete UE/UPFfree5gc/ci-testverification remains pending; this PR does not claim an end-to-end fix by itself.Validation:
go test ./...passed.go build ./...passed.go test -race ./internal/context ./internal/util ./internal/sbi/processorpassed.golangci-lint v2.11.4 runpassed with 0 issues.