Skip to content

fix: add color palette picker to label config#1081

Open
Gadha2311 wants to merge 5 commits into
frappe:developfrom
Gadha2311:donut-color-palette
Open

fix: add color palette picker to label config#1081
Gadha2311 wants to merge 5 commits into
frappe:developfrom
Gadha2311:donut-color-palette

Conversation

@Gadha2311
Copy link
Copy Markdown
Contributor

@Gadha2311 Gadha2311 commented Apr 21, 2026

The color palette option allows you to control the visual appearance of the donut chart by selecting predefined color themes such as Default, Pastel, Bold, Earth, and Ocean. Each palette applies a distinct set of colors to the chart segments, helping improve readability and visual appeal. You can choose a palette based on your preference or the context of the data, ensuring better differentiation between slices and a more meaningful presentation of insights.

@Gadha2311 Gadha2311 changed the title fix:add color palette picker to label config fix: add color palette picker to label config May 8, 2026
@Gadha2311 Gadha2311 force-pushed the donut-color-palette branch from 78a058d to 347e68c Compare May 8, 2026 06:15
@nextchamp-saqib
Copy link
Copy Markdown
Member

Hey, thanks for the PR!

The feature works properly, but the config layout and control doesn't look good.
Can you make the palette picker as a dropdown? something like below (this is from older v2 UI)

CleanShot 2026-05-08 at 11 52 23@2x

The inline colors can be shown in the dropdown along with the names

CleanShot 2026-05-08 at 12 01 43@2x

You can check the v2 code for reference

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.23%. Comparing base (6c63e68) to head (35c8673).
⚠️ Report is 3151 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (6c63e68) and HEAD (35c8673). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (6c63e68) HEAD (35c8673)
4 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1081       +/-   ##
============================================
- Coverage    51.16%   39.23%   -11.94%     
============================================
  Files           62       75       +13     
  Lines         3979     5589     +1610     
============================================
+ Hits          2036     2193      +157     
- Misses        1943     3396     +1453     
Flag Coverage Δ
server 39.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gadha2311
Copy link
Copy Markdown
Contributor Author

@nextchamp-saqib Thanks for the feedback!
I’ve implemented the dropdown-style palette selector for the custom case as well. For the custom case, clicking on a color preview now opens the full color palette for selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants