Skip to content

Drop EOL k8s version checks and fix hpa-gunicorn target deployment - #306

Open
plaes wants to merge 2 commits into
frappe:mainfrom
plaes:fix/drop-k8s-1.23-hpa-check
Open

plaes wants to merge 2 commits into
frappe:mainfrom
plaes:fix/drop-k8s-1.23-hpa-check

Conversation

@plaes

@plaes plaes commented Nov 9, 2026

Copy link
Copy Markdown

Two HPA-related cleanups:

  1. Drop EOL k8s version checks as <1.23 is EOL since 2023
  2. Fix wrong apps/v2 target ref, which was probably a copy-paste error from 6a55059.

plaes added 2 commits November 9, 2026 11:38
HPAs already emit autoscaling/v2, so the targetAverageUtilization fallback
is dead code.
apps/v2 does not exist; the HPA controller could not resolve the Deployment.
Probably a copy-paste error from 6a55059 (autoscaling/v1 -> autoscaling/v2),
which bumped scaleTargetRef in this file only.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant