Align eslint with other projects#615
Conversation
|
Not yet finished since complicated type errors are still present |
# Conflicts: # src/main/frontend/app/hooks/use-handle-types.ts # src/main/frontend/app/routes/studio/canvas/nodetypes/components/handle-menu.tsx # src/main/frontend/app/routes/studio/canvas/nodetypes/components/handle.tsx # src/main/frontend/app/routes/studio/canvas/nodetypes/frank-node.tsx # src/main/frontend/app/routes/studio/canvas/nodetypes/group-node.tsx # src/main/frontend/app/routes/studio/canvas/nodetypes/start-node.tsx # src/main/frontend/app/routes/studio/xml-to-json-parser.ts # src/main/frontend/app/stores/flow-store.ts
|
Only one lint error left, this will be solved in #610 |
|
philipsens
left a comment
philipsens
left a comment
There was a problem hiding this comment.
So many return types >.<
Sometimes it does look like a lot of boilerplate. Like in the store where the arrow function gets wrapped with persist(). But I guess that could get refactored to a type later on.
Nice to see some abbreviations fixed.
Fixed order in editor-data-provider.ts
Toasts moved and separated is a good choice.
Why is the eslint-rules ignored in the flow.tsx? Is there an issue or something to fix that later?
|
Because of all the changes that are gonna happen once #610 is ready to take on all the linting changes |
I saw the other PR and instantly understood it. Thanks for clarifying. |
2 participants
Big linting changes