Fix jail_set - #41
Open
vbotka wants to merge 1 commit into
Open
Conversation
* Replace 'not _val' by '_val is None'. Former condition falsely selects and skips 0 * Remove redundant test '_property in _existing_props.keys()'. Already tested by the first condition in the loop. * Replace loop need_start by testing intersect of the lists. * Remove unused vars rc=1, out="", cmd="" * Initialization of propval not needed. * The dash '-' already tested. Test string instead. * Quote string values. * Tested (in the branch current).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested by the first condition in the loop
Tested ( in the branch current)