Repository navigation
Update for nasa/fprime#5996: add pktType to FrameContext - #28
Merged
LeStarch merged 1 commit intoSep 28, 2026
Merged
Conversation
Sync the project ComCfg.fpp override with the FrameContext change merged in nasa/fprime#5996 (SppPacketType enum and pktType field), which Svc/Ccsds SpacePacketFramer/Deframer now require. Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
LeStarch
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Sync this project's
ComCfg.fppoverride (config/FPrimeCfsConfig/ComCfg.fpp) with theComCfg::FrameContextchange merged in nasa/fprime#5996 (nasa/fprime#5996):SppPacketTypeenum (SPP_TELEMETRY = 0,SPP_COMMAND = 1, defaultSPP_TELEMETRY)pktType: SppPacketTypetoFrameContext(defaultSppPacketType.SPP_TELEMETRY)Rationale
Since #5996,
Svc/Ccsds/SpacePacketFramerandSpacePacketDeframercallFrameContext::set_pktType()/get_pktType(). Because this project overridesComCfg.fpp, the generatedFrameContextlacked those members and the framework no longer compiles against current F´devel:All project-specific
FrameContextfields are retained; this is purely additive. The field is also harmless against the currently pinned F´ submodule (older framework code simply does not read it).Testing/Review Recommendations
Built
fprime-community/fprime_cfs_reference(make SIMULATION=native prep && make) withlibs/fprimeon currentdevel(1189e37) and this change inlibs/fprime_cfsplus the companion fprime_app override update: full mission build succeeds,SpacePacketFramer.cpp/SpacePacketDeframer.cppcompile, and the generatedFrameContextSerializableAc.hppcontainspktType. Companion PR on fprime_app applies the same change to itsfprime_config/config/ComCfg.fpp.Generative AI was used in this contribution (Devin); reviewed by a human before merge.