Repository navigation
Conversation
…d bridges; replace deprecated getBuffLength() Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
LeStarch
requested changes
Aug 5, 2026
LeStarch
left a comment
Contributor
There was a problem hiding this comment.
- No UTs, nor requirements. Please add UTs that trace requirements.
- This seems to do a reallocate and copy. Just move the data pointer and skip the allocate.
Was this designed with the component development process? If not, please check that process and ensure it is retrofitted in here.
Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Contributor
Author
|
Review feedback addressed:
Revalidated end to end against the reference deployment: telemetry/events decode in the GDS and a CMD_NO_OP round trip completes. |
…dges Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Contributor
Author
|
Per the review direction, |
LeStarch
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Replaces the deprecated
Fw::Buffer::getBuffLength()call withgetSize()inCfsAppBridge, fixing a-Werror=deprecated-declarationsbuild failure against current F Prime devel.Note: this PR originally added
CfsTlmStripper. Per review discussion, that component is only needed when bridging to F Prime ground operations, so it has moved to fprime-community/fprime_gds#7 (with SDD requirements and requirements-traced UTs).Rationale
Building the reference against current F Prime devel fails on the deprecated API.
Testing/Review Recommendations
Build fprime_cfs_reference against F Prime devel; verified locally with a full reference build and GDS round trip.
Future Work
None.