Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a new tool
fpp-querywhich is a syntax-only FPP tool for matching to AST nodes and generating file listings. It is essentially a general-purpose version offpp-filenameswhich is meant for custom FPP autocoders to provide a very fast CMake configure which needs to query every.fppfile against every FPP autocoder.I found that when working which Python to provide both autocoding and the configure-stage filenames, CMake configuration (
fprime-util generate) slowed down considerably. This tool replaces filename listing step.It works by traversing the AST looking for configured
nodekinds to match. Then it converts them into a JSONserde_json::Valueand matches awhenpredicate to them. The predicate uses a simple expression-based DSL to match to different kinds of rules. All the rules are driven by.tomlfiles which are hooked intofpp-queryvia the--ruleoption (required)The tool also comes with some "presets" which provide the same functionality of
fpp-filenamesand all the option variants of the tool. These presets can be useful for examples/reference.