Fix: Improve localStorage error handling in storageHelper.js#364
Closed
FrankOHara43 wants to merge 2 commits into
Closed
Fix: Improve localStorage error handling in storageHelper.js#364FrankOHara43 wants to merge 2 commits into
FrankOHara43 wants to merge 2 commits into
Conversation
…compatibility Signed-off-by: FrankOHara43 <aryaswaraj5@gmail.com>
Signed-off-by: FrankOHara43 <aryaswaraj5@gmail.com>
Author
|
Thank you for testing it out!!! |
github-actions
Bot
added
the
has merge conflicts
|
This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After logging into the UI page hydration error was being rendered due to the localStorage value being missing or malformed.
Changes
-Added checks for
null,undefined, andemptystring values fromlocalStorage.getItem(key).-Wrapped
JSON.parsein atry-catchblock to prevent runtime errors if the stored value is not valid JSON.-Added error logging for JSON parsing failures.