Skip to content

fix : style guide violation#1196

Merged
jalvesz merged 1 commit into
fortran-lang:masterfrom
jalvesz:pure
Jul 10, 2026
Merged

fix : style guide violation#1196
jalvesz merged 1 commit into
fortran-lang:masterfrom
jalvesz:pure

Conversation

@jalvesz

@jalvesz jalvesz commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Some previous PR introduced a style guide violation regarding where the module attibute should be. This produces spurious builds with CMake < 3.26

@jvdp1 jvdp1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It can be merged. Thank you @jalvesz

@jalvesz jalvesz merged commit 478ef58 into fortran-lang:master Jul 10, 2026
75 of 76 checks passed
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.60%. Comparing base (d068e75) to head (2594e4f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
- Coverage   68.62%   68.60%   -0.02%     
==========================================
  Files         409      409              
  Lines       13784    13784              
  Branches     1559     1559              
==========================================
- Hits         9459     9457       -2     
- Misses       4325     4327       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants